feat: JS clients can provide custom grpc transports #6476
Conversation
niloc132
added
jsapi
NoDocumentationNeeded
ReleaseNotesNeeded
web/client-api/src/test/java/io/deephaven/web/client/api/grpc/GrpcTransportGwtTest.java
Outdated
Show resolved
Hide resolved
web/client-api/src/test/java/io/deephaven/web/client/api/grpc/GrpcTransportGwtTest.java
Outdated
Show resolved
Hide resolved
| // if (map.has("fetch")) { | ||
| // fetch = map.getAsAny("fetch").uncheckedCast(); | ||
| // } |
There was a problem hiding this comment.
Could be, though we thought we would want to have it - in theory this is a simpler version of what we just implemented.
If we do decide we'll never want it, I think I'd want to expose canonical factories for fetch and websocket, so users can just assign them if they want to direct which built-in factory to use.
| } | ||
| return useWebsockets; | ||
| public boolean supportsClientStreaming() { | ||
| return getOptions().transportFactory.getSupportsClientStreaming(); |
There was a problem hiding this comment.
While it's correct since the transportFactory is always initialized correctly by IdeConnection, in ConnectionOptions it annotates transportFactory as JsNullable. I guess we'd just throw here if it was null anyways?
There was a problem hiding this comment.
Yes - the annotations are for the sake of the generated TS and docs ("you can populate this or not"). In theory the compiler could take them seriously, but in practice Java isn't expressive enough about nulls, even with this annotation (static analysis is used instead, to solve for fields/variables that can never be null).
Provides a contract for client applications to use a custom http/2 implementation. Roughly abstracted from our TypeScript grpc-web library, with a few rough edges taken off, and no external dependencies.
Two integration tests are included, one which requires https (presently only possible with manual testing, see #6421), and one which pretends to contact the server but really responds to every request with a "success" response and no payload.
No documentation required at this time, generated typescript includes details on the new APIs.
Fixes #6404