Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Removed some unused Parquet APIs #6373

Merged
merged 3 commits into from
Nov 15, 2024
Merged

refactor: Removed some unused Parquet APIs #6373

merged 3 commits into from
Nov 15, 2024

Conversation

malhotrashivam
Copy link
Contributor

@malhotrashivam malhotrashivam commented Nov 13, 2024 •
edited
Loading

Originally added in #5989, moved as a separate PR for ease of review/testing.

Breaking Changes:

  • Removed optional paramater extraColumns from io.deephaven.parquet.table.MappedSchema.create
  • Removed these methods;
    • ParquetInstructions::setDefaultCompressionCodecName
    • ParquetInstructions::getDefaultCompressionCodecName
    • ParquetInstructions::setDefaultMaximumDictionaryKeys
    • ParquetInstructions::getDefaultMaximumDictionaryKeys
    • ParquetInstructions::setDefaultMaximumDictionarySize
    • ParquetInstructions::getDefaultMaximumDictionarySize
    • ParquetInstructions::setDefaultTargetPageSize
    • ParquetInstructions::getDefaultTargetPageSize

@malhotrashivam malhotrashivam added parquet Related to the Parquet integration NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Nov 13, 2024
@malhotrashivam malhotrashivam added this to the 0.37.0 milestone Nov 13, 2024
@malhotrashivam malhotrashivam self-assigned this Nov 13, 2024
@malhotrashivam malhotrashivam changed the title Refactored out some unused Parquet APIs refactor: Refactored out some unused Parquet APIs Nov 13, 2024
@malhotrashivam malhotrashivam mentioned this pull request Nov 13, 2024
Merged
rcaudy
rcaudy reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@malhotrashivam malhotrashivam changed the title refactor: Refactored out some unused Parquet APIs refactor: Removed out some unused Parquet APIs Nov 15, 2024
@malhotrashivam malhotrashivam merged commit 9692a02 into deephaven:main Nov 15, 2024
21 checks passed
@malhotrashivam malhotrashivam changed the title refactor: Removed out some unused Parquet APIs refactor: Removed some unused Parquet APIs Nov 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abaranec abaranec abaranec approved these changes

@rcaudy rcaudy rcaudy approved these changes

@lbooker42 lbooker42 Awaiting requested review from lbooker42

Assignees

@malhotrashivam malhotrashivam

Labels
breaking NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. parquet Related to the Parquet integration
Projects
None yet
Milestone
0.37.0
Development

Successfully merging this pull request may close these issues.
3 participants
@malhotrashivam @abaranec @rcaudy