Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't try to expose TypedTicket through JS API #6212

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: Don't try to expose TypedTicket through JS API #6212

merged 1 commit into from
Oct 18, 2024

Conversation

niloc132
Copy link
Member

Fixes #5911

@niloc132 niloc132 added documentation Improvements or additions to documentation jsapi NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Oct 18, 2024
@niloc132 niloc132 added this to the 0.37.0 milestone Oct 18, 2024
@niloc132 niloc132 requested a review from bmingles October 18, 2024 16:17
@bmingles
Copy link
Contributor

Looks good. I built locally:

./gradlew :web-client-api:types:assemble

and confirmed cat web/client-api/build/ts-types/types.d.ts no longer contains TypedTicket references.

bmingles
bmingles approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niloc132 niloc132 merged commit 8e79f7a into deephaven:main Oct 18, 2024
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmingles bmingles bmingles approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation jsapi NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
0.37.0
Development

Successfully merging this pull request may close these issues.

@deephaven/jsapi-types reference dhinternal.io.deephaven.proto.ticket_pb.TypedTicket which is not defined
2 participants
@niloc132 @bmingles