Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(csharp/ExcelAddIn): allow insecure JSON URL for Core+; choose python/groovy for Core #6008

Merged
merged 1 commit into from
Aug 31, 2024
Merged

feat(csharp/ExcelAddIn): allow insecure JSON URL for Core+; choose python/groovy for Core #6008

merged 1 commit into from
Aug 31, 2024

Conversation

kosak
Copy link
Contributor

@kosak kosak commented Aug 30, 2024

Add GUI elements (and wire them up)

  1. ... for allowing insecure JSON URL fetches for Enterprise Core+
  2. ...for selecting the session type (groovy vs python) for Community Core
  3. ...for closing the "Set Credentials" dialog box upon setting the credentials

@kosak kosak requested a review from jcferretti August 30, 2024 23:57
@kosak kosak self-assigned this Aug 30, 2024
@kosak kosak added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Aug 30, 2024
@kosak kosak merged commit afbb84b into deephaven:main Aug 31, 2024
18 of 20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
@kosak kosak deleted the kosak_insecure branch August 31, 2024 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcferretti jcferretti jcferretti approved these changes

Assignees

@kosak kosak

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kosak @jcferretti