Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump docker images #5971

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

devinrsmith
Copy link
Member

@devinrsmith devinrsmith commented Aug 22, 2024

The environment variable for building py-client-ticking needed to be updated from CFLAGS TO CPPFLAGS; this change was necessary because the newer version of setuptools in the manylinux base image seems to no longer include CFLAGS.

@devinrsmith devinrsmith added this to the 0.37.0 milestone Aug 22, 2024
@devinrsmith devinrsmith self-assigned this Aug 22, 2024
@devinrsmith
Copy link
Member Author

Failing with:

> Task :py-client-ticking:pyClientTickingWheel-cp310-cp310Run FAILED
  from pkg_resources import parse_version
src/pydeephaven_ticking/_core.cpp:1283:10: fatal error: deephaven/dhcore/chunk/chunk.h: No such file or directory
 1283 | #include "deephaven/dhcore/chunk/chunk.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
error: command '/opt/rh/devtoolset-10/root/usr/bin/g++' failed with exit code 1

This is necessary for to acount for bump in setuptools in manylinux image.
@devinrsmith devinrsmith marked this pull request as ready for review August 23, 2024 14:08
@devinrsmith devinrsmith enabled auto-merge (squash) August 23, 2024 14:25
@devinrsmith devinrsmith merged commit a0dcbbf into deephaven:main Aug 23, 2024
17 checks passed
@devinrsmith devinrsmith deleted the nightly/bump-docker-imgs branch August 23, 2024 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants