refactor!: Remove tracking of "culprit" from Require methods #5739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
NoDocumentationNeeded
breaking
ReleaseNotesNeeded
|
The first commit simplifies RequirementFailure to match AssertionFailure, and can stand alone even if we want to drop the second. I checked Core+, and RequirementFailure is never explicitly used, nor are any of the overloads that take a depth param. The patch presently increases the size of the file rather than shrinking it - I think I accidentally inlined something that was used in many places, probably one of the |
It has never appeared in a DHC issue, nor in DHC slack, and the last DHE slack message to use it in a mildly helpful way was more than two years ago.
rcaudy
reviewed
Jul 11, 2024
Base/src/test/java/io/deephaven/base/TestLowGarbageArrayIntegerMap.java
Outdated
Show resolved
Hide resolved
…rMap.java Co-authored-by: Ryan Caudy <[email protected]>
rcaudy
approved these changes
Jul 11, 2024
|
Nightly build passed: https://github.com/niloc132/deephaven-core/actions/runs/9897209491 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string
culpritas a marker for pointing to an issue in a stack trace has never appeared in a DHC issue, nor in DHC slack, and the last DHE slack message to use it in a mildly helpful way was more than two years ago.This patch removes the functionality from
RequirementFailure, and also removes any overload of a method inRequirethat would allow callers to customize the depth within the stack that should be marked.Partial #188