C++ Client: fix WAvg, fix noexcept, optimize PercentileBy, fix comments #5684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosak
added
NoDocumentationNeeded
NoReleaseNotesNeeded
kosak
force-pushed
the
kosak_small-cleanups
branch
from
06efbe2 to
296ea7f
Compare
jcferretti
previously approved these changes
Jun 26, 2024
jcferretti
approved these changes
Jun 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes in this PR:
WAvgwas wrong; it didn't have an initial "weight" argument. This was not detected because there is no code or test that calls this entry point. (We still don't have a test that calls it)Aggregateshould not be markednoexcept. The Visual Studio compiler (if I recall correctly) is picky about this.PercentileByinTableHandleImpl, reduce it to one. And then have all thePercentileByentry points inTableHandlecall the same one.