Added support for (start<0 & stop>0) in slice #4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotrashivam
added
feature request
malhotrashivam
changed the title
lbooker42
reviewed
Jun 27, 2023
nbauernfeind
previously approved these changes
Jun 28, 2023
nbauernfeind
approved these changes
Jul 12, 2023
|
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/2902 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request, closes #3130
Change description: Earlier, an error was generated in this scenario. After this change, a subset of rows will be returned where start will be counted from the end of table (inclusively) and stop from the beginning. This change also fixes one bug where ADD_ONLY was incorrectly being propagated from parent to a child table in case of slice operation.
Documentation update: We need to update both the java and python documentation to reflect this change.
Earlier, if (start<0 & stop>0), an error was generated. Now, a subset of rows will be returned. For example, slice(-3, 5)
will return all rows starting from the third-last row to the fifth row of the table. If there are no rows between these positions, the function will return an empty table.
Note that index 5 corresponds to the sixth row in the table, so we are excluding the sixth row and ending the subset at the fifth row.