Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper double checked locking for EngineMetrics#getProcessInfo #3636

Merged

Conversation

devinrsmith
Copy link
Member

Follow-up fix for #3591

@devinrsmith devinrsmith added bug Something isn't working NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Mar 30, 2023
@devinrsmith devinrsmith added this to the Mar 2023 milestone Mar 30, 2023
@devinrsmith devinrsmith requested a review from jcferretti March 30, 2023 23:46
@devinrsmith devinrsmith self-assigned this Mar 30, 2023
@devinrsmith
Copy link
Member Author

Observed CI run that produced

java.lang.IllegalStateException: ProcessInfo already created with ID ProcessUniqueId{value=f83c65c4-524a-46b2-83f1-d3a538e88bcb}
        at io.deephaven.process.ProcessInfoConfig.createForCurrentProcess(ProcessInfoConfig.java:71)
        at io.deephaven.engine.table.impl.util.EngineMetrics.getProcessInfo(EngineMetrics.java:36)
        at io.deephaven.engine.tablelogger.impl.memory.UpdatePerformanceLogLoggerMemoryImpl.<init>(UpdatePerformanceLogLoggerMemoryImpl.java:28)
        at io.deephaven.engine.tablelogger.impl.memory.EngineTableLoggersFactoryMemoryImpl.updatePerformanceLogLogger(EngineTableLoggersFactoryMemoryImpl.java:42)
        at io.deephaven.engine.table.impl.perf.UpdatePerformanceTracker.<init>(UpdatePerformanceTracker.java:75)
        at io.deephaven.engine.table.impl.perf.UpdatePerformanceTracker.getInstance(UpdatePerformanceTracker.java:60)
        at io.deephaven.extensions.barrage.table.BarrageTable.<init>(BarrageTable.java:144)
        at io.deephaven.extensions.barrage.table.BarrageRedirectedTable.<init>(BarrageRedirectedTable.java:59)
        at io.deephaven.extensions.barrage.table.BarrageTable.make(BarrageTable.java:397)
        at io.deephaven.extensions.barrage.table.BarrageTable.make(BarrageTable.java:370)
        at io.deephaven.extensions.barrage.util.ArrowToTableConverter.parseSchema(ArrowToTableConverter.java:167)
        at io.deephaven.server.arrow.ArrowFlightUtil$DoPutObserver.onNext(ArrowFlightUtil.java:165)
        at io.deephaven.server.arrow.ArrowFlightUtil$DoPutObserver.onNext(ArrowFlightUtil.java:107)
        at io.grpc.stub.ServerCalls$StreamingServerCallHandler$StreamingServerCallListener.onMessage(ServerCalls.java:262)
        at io.grpc.ForwardingServerCallListener.onMessage(ForwardingServerCallListener.java:33)
        at io.deephaven.server.session.SessionServiceGrpcImpl$SessionServiceCallListener.lambda$onMessage$0(SessionServiceGrpcImpl.java:352)
        at io.deephaven.server.session.SessionServiceGrpcImpl.rpcWrapper(SessionServiceGrpcImpl.java:393)
        at io.deephaven.server.session.SessionServiceGrpcImpl$SessionServiceCallListener.onMessage(SessionServiceGrpcImpl.java:352)

@devinrsmith devinrsmith merged commit 29f6be4 into deephaven:main Mar 31, 2023
@devinrsmith devinrsmith deleted the get-process-info-double-checked-lock branch March 31, 2023 00:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants