Deephaven-in-docker gradle wiring support for env vars #3536
Conversation
Enables tests to control the environment variables of a running deephaven server in docker, to configure the jvm or deephaven itself. This patch also modifies py/go/cpp tests to only ask for a max od 512mb of heap, to avoid issues running in docker desktop. Fixes deephaven#3535
niloc132
added
test
docker
NoDocumentationNeeded
NoReleaseNotesNeeded
There was a problem hiding this comment.
LGTM.
As a general note: by default, JVM ergonomics optimizes for a different GC collector when the heap size is small. For the deephaven server, we are explicitly forcing non-ergonomic defaults via JAVA_OPTS=-XX:+UseG1GC -XX:MaxGCPauseMillis=100 -XX:+UseStringDeduplication. Not that I think there is pressing needs, but if we find ourselves needing to further optimize integration tests cases for small heap sizes, we may wish to override the server defaults and explicitly set JAVA_OPTS instead of START_OPTS.
|
Yeah, I deliberately set START_OPTS to let those settings continue to be used, as that is what our docker-compose example does as well, under the assumption that we probably want tests to be tweaking the server no more than is obvious from examples. I considered briefly just offering a list for jvm args, maybe a map for system properties, but it seemed not-too-dirty to just directly expose all env vars so we could decide when to set JAVA_OPTS, EXTRA_CLASSPATH as well as and when we need them. |
Enables tests to control the environment variables of a running deephaven server in docker, to configure the jvm or deephaven itself.
This patch also modifies py/go/cpp tests to only ask for a max of 512mb of heap, to avoid issues running in docker desktop.
Fixes #3535