Stop UGP NotificationProcessor From Silently Swallowing Errors #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
bug
rcaudy
reviewed
Mar 9, 2023
engine/updategraph/src/main/java/io/deephaven/engine/updategraph/UpdateGraphProcessor.java
Outdated
Show resolved
Hide resolved
engine/updategraph/src/main/java/io/deephaven/engine/updategraph/UpdateGraphProcessor.java
Outdated
Show resolved
Hide resolved
engine/updategraph/src/main/java/io/deephaven/engine/updategraph/UpdateGraphProcessor.java
Outdated
Show resolved
Hide resolved
rcaudy
previously approved these changes
Mar 9, 2023
rcaudy
approved these changes
Mar 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Array Column Access PR nightly
testSerialwas timing out. After isolating the issue to a specific FuzzerTest, I was able to observe unwanted behavior when running from IJ.In particular,
RefreshingTableTestCasethrows anAssertionErrorviaTestCase.fail()if a table propagates a bad update. I've added an additional check to validateAPPEND_ONLYtables. This error was causing the notification processing threads to exit, eventually starving the notification queue of threads to process them. The UGP was waiting for Godot, causing CI'stestSerialto be forced to exit after 6 hrs.This did not occur in my testing because the error was not common enough to starve my executor from processing threads. The machine I was using has 8 cores, but I suspect CI is at 2.
I've come up with a fix that should catch losing notification threads in non-test scenarios, too.
This is a new issue caused by enabling multi-threaded processing by default.
Running nightlies in case there were any tests silently failing: https://github.com/nbauernfeind/deephaven-core/actions/runs/4379371283