Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the use of Python callable's attributes in query strings #3509

Merged
merged 5 commits into from
Mar 10, 2023
Merged

Support the use of Python callable's attributes in query strings #3509

merged 5 commits into from
Mar 10, 2023

Conversation

jmao-denver
Copy link
Contributor

Fixes #3508

@jmao-denver jmao-denver added this to the Mar 2023 milestone Mar 8, 2023
@jmao-denver jmao-denver requested a review from jjbrosnan March 8, 2023 21:35
@jmao-denver jmao-denver self-assigned this Mar 8, 2023
@jmao-denver jmao-denver marked this pull request as draft March 9, 2023 01:40
@jmao-denver jmao-denver force-pushed the 3508-pycallable-attributes branch from 965ba3e to 89d46c6 Compare March 9, 2023 03:08
@jmao-denver jmao-denver marked this pull request as ready for review March 9, 2023 03:08
rcaudy
rcaudy previously approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to run nightlies before merging.

@jmao-denver jmao-denver requested a review from rcaudy March 10, 2023 04:07
@jmao-denver
Copy link
Contributor Author

jmao-denver commented Mar 10, 2023 •
edited
Loading

Please be sure to run nightlies before merging.

Nightly check in my fork has finished successfully.

rcaudy
rcaudy previously approved these changes Mar 10, 2023
View reviewed changes
@jmao-denver jmao-denver requested a review from rcaudy March 10, 2023 15:50
rcaudy
rcaudy previously approved these changes Mar 10, 2023
View reviewed changes
jjbrosnan
jjbrosnan reviewed Mar 10, 2023
View reviewed changes
Copy link
Contributor

@jjbrosnan jjbrosnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response to Chip's comment about tests.

@jmao-denver jmao-denver merged commit 36facaf into deephaven:main Mar 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
@jmao-denver jmao-denver deleted the 3508-pycallable-attributes branch March 31, 2023 03:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jjbrosnan jjbrosnan jjbrosnan approved these changes

@chipkent chipkent chipkent approved these changes

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

Assignees

@jmao-denver jmao-denver

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. query engine
Projects
None yet
Milestone
Mar 2023
Development

Successfully merging this pull request may close these issues.

Can't use attributes on Python callable objects in queries
4 participants
@jmao-denver @chipkent @rcaudy @jjbrosnan