-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dropColumns as TableOperations / TableSpec #3474
Conversation
This is in support of deephaven#3473, where for adapting implementation purposes, it's cleaner and easier to use dropColumns
For a bit more context, the SQL query: my_time = time_table("00:00:01").update_view(
["I=ii%10==0?null:ii", "B=ii%11==0?null:ii%3==0"]
) SELECT
*
FROM
my_time
ORDER BY "B", "Timestamp" DESC produces the logical plan
notice that the hierarchy produced has sort being executed after the project, yet still refers to the columns by reference. With the DHC implementation, I'd like to adapt all of the tables into "reference" space, execute the plan, and then remove the extra references. In this implementation, instead of using a
|
I'd potentially like to follow this up with |
So - my current SQL implementation does not rely on dropColumns anymore. That said, it might be nice to get these improvements over the line regardless? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caught up to head, still need to discuss open issue.
This is in support of #3473, where for adapting implementation purposes, it's cleaner and easier to use dropColumns.