Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add read_sql in the dbc package #3434

Merged
merged 6 commits into from
Mar 1, 2023
Merged

Add read_sql in the dbc package #3434

merged 6 commits into from
Mar 1, 2023

Conversation

jmao-denver
Copy link
Contributor

Fixes #3430

  1. add the read_sql() function. Note that it is a package-level function so the handling of the optional dependency on ConnectorX is different from the adbc/odbc modules
  2. clean up existing code a bit

@jmao-denver jmao-denver added this to the Feb 2023 milestone Feb 13, 2023
@jmao-denver jmao-denver self-assigned this Feb 13, 2023
chipkent
chipkent requested changes Feb 24, 2023
View reviewed changes
Integrations/build.gradle Outdated Show resolved Hide resolved
py/server/deephaven/dbc/__init__.py Outdated Show resolved Hide resolved
py/server/deephaven/dbc/__init__.py Outdated Show resolved Hide resolved
py/server/deephaven/dbc/__init__.py Outdated Show resolved Hide resolved
devinrsmith
devinrsmith requested changes Feb 28, 2023
View reviewed changes
docker/registry/protoc-base/gradle.properties Outdated Show resolved Hide resolved
docker/registry/cpp-client-base/gradle.properties Outdated Show resolved Hide resolved
py/server/tests/test_dbc.py Outdated Show resolved Hide resolved
docker/server-jetty/src/main/server-jetty/requirements.txt Outdated Show resolved Hide resolved
@jmao-denver jmao-denver requested a review from devinrsmith March 1, 2023 01:28
devinrsmith
devinrsmith previously approved these changes Mar 1, 2023
View reviewed changes
py/server/tests/test_dbc.py Show resolved Hide resolved
chipkent
chipkent requested changes Mar 1, 2023
View reviewed changes
py/server/deephaven/dbc/__init__.py Show resolved Hide resolved
py/server/deephaven/dbc/__init__.py Outdated Show resolved Hide resolved
py/server/deephaven/dbc/__init__.py Outdated Show resolved Hide resolved
py/server/deephaven/dbc/__init__.py Outdated Show resolved Hide resolved
py/server/deephaven/dbc/__init__.py Show resolved Hide resolved
py/server/tests/test_dbc.py Show resolved Hide resolved
docker/server-jetty/src/main/server-jetty/requirements.txt Show resolved Hide resolved
docker/server/src/main/server-netty/requirements.txt Show resolved Hide resolved
devinrsmith
devinrsmith previously approved these changes Mar 1, 2023
View reviewed changes
@jmao-denver jmao-denver requested a review from devinrsmith March 1, 2023 23:05
@jmao-denver jmao-denver merged commit b818081 into deephaven:main Mar 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2023
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

How-to: https://github.com/deephaven/deephaven.io/issues/2235
Conceptual: https://github.com/deephaven/deephaven.io/issues/2237
Reference: https://github.com/deephaven/deephaven.io/issues/2236
Blog: https://github.com/deephaven/deephaven.io/issues/2238

@jmao-denver jmao-denver deleted the 3430-add-read_sql branch March 31, 2023 03:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devinrsmith devinrsmith devinrsmith approved these changes

@chipkent chipkent chipkent approved these changes

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

@jcferretti jcferretti Awaiting requested review from jcferretti jcferretti is a code owner

Assignees

@jmao-denver jmao-denver

Labels
DocumentationNeeded python-server-side ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
Feb 2023
Development

Successfully merging this pull request may close these issues.

add read_sql() to the relational data ingestion API
4 participants
@jmao-denver @deephaven-internal @chipkent @devinrsmith