JS API authentication via Flight v2 #3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
formed status objects
niloc132
added
jsapi
NoDocumentationNeeded
authentication
ReleaseNotesNeeded
niloc132
commented
Jan 27, 2023
server/src/main/java/io/deephaven/server/arrow/FlightServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/session/SessionService.java
Outdated
Show resolved
Hide resolved
niloc132
commented
Jan 27, 2023
web/client-api/src/main/java/io/deephaven/web/client/api/CoreClient.java
Outdated
Show resolved
Hide resolved
niloc132
commented
Jan 27, 2023
| metadata().set("authorization", authorization); | ||
| CustomEventInit init = CustomEventInit.create(); | ||
| init.setDetail(new JsRefreshToken(authorization.getAt(0), sessionTimeoutMs)); | ||
| info.fireEvent(EVENT_REFRESH_TOKEN_UPDATED, init); |
There was a problem hiding this comment.
i have not tested this part yet
niloc132
commented
Jan 27, 2023
web/client-api/src/main/java/io/deephaven/web/client/api/WorkerConnection.java
Outdated
Show resolved
Hide resolved
web/client-api/src/main/java/io/deephaven/web/client/api/WorkerConnection.java
Outdated
Show resolved
Hide resolved
vbabich
previously approved these changes
Jan 27, 2023
mofojed
reviewed
Jan 27, 2023
web/client-api/src/main/java/io/deephaven/web/client/api/CoreClient.java
Show resolved
Hide resolved
web/client-api/src/main/java/io/deephaven/web/client/api/CoreClient.java
Show resolved
Hide resolved
web/client-api/src/main/java/io/deephaven/web/client/api/CoreClient.java
Show resolved
Hide resolved
...ent-api/src/main/java/io/deephaven/web/client/api/barrage/stream/HandshakeStreamFactory.java
Outdated
Show resolved
Hide resolved
web/client-api/src/main/java/io/deephaven/web/client/ide/IdeConnection.java
Outdated
Show resolved
Hide resolved
niloc132
force-pushed
the
2564-js-authentication
branch
from
47aa4d0 to
c481992
Compare
mofojed
approved these changes
Jan 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS API changes necessary for #2564, moving from the deprecated SessionService.newSession call to Flight v2 authentication. Since the gRPC-web client in use doesn't support interceptors or even reading headers from requests, we only use FlightService.handshake to keep the session alive and rotate tokens, with a hand-written implementation rather than the generated version.
Documentation will follow when the rest of the ticket is closed.
Partial #2564