Port DH-11656: More efficiently null sparse array sources #3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
query engine
NoDocumentationNeeded
port
ReleaseNotesNeeded
cpwright
approved these changes
Jan 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the
setNullport was completed in some of Larry's work this past summer.I dropped
setNull(long key)from the implementations ofSingleValueSources in favor of a final impl in the abstract base class that redirects tosetNull().Internal JIRA DH-11656
Internal Commit: b4ce7833096c56ae0ae166d252ebf952ef167a8e
Nightlies are here.