-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update server-base and server-slim-base to production-like images #3336
Update server-base and server-slim-base to production-like images #3336
Conversation
This was a longer-than-expected effort to close the gap between production images, and integration testing images. The big updates: the base images are now based on ubuntu:22.04 (instead of an old debian), and the python version is now 3.10 (instead of an old 3.7). These images are now being produced with Dockerfiles from https://github.com/deephaven/deephaven-server-docker that are as similar to the production images as possible. Necessary testing fixes already done in deephaven#3331
Looks like some sphinx typing/documentation issues w/ 3.10. |
I was able to make the sphinx task pass locally with the following change.
|
I also needed to update the location of grpc_health_probe to match the production location |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and partially tested locally
sphinx/source/conf.py
Outdated
'-XX:MinRAMPercentage=70.0', | ||
'-XX:MaxRAMPercentage=80.0', | ||
|
||
# Allow netty to (reflectively) access java.nio.Buffer fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this valid? Only netty? Does sphinx still use netty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the netty part is too specific. It looks like it's also required by arrow, and potentially other low-level components. I've removed the explicit reference to "netty".
This was a longer-than-expected effort to close the gap between production images, and integration testing images. The big updates: the base images are now based on ubuntu:22.04 (instead of an old debian), and the python version is now 3.10 (instead of an old 3.7). These images are now being produced with Dockerfiles from https://github.com/deephaven/deephaven-server-docker that are as similar to the production images as possible.
Necessary testing fixes already done in #3331