Port DH-11625: Improve Would Match Filtering #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
query engine
NoDocumentationNeeded
port
NoReleaseNotesNeeded
nbauernfeind
force-pushed
the
dh_11625
branch
from
ee35d3b to
f084534
Compare
cpwright
approved these changes
Jan 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal JIRA Ticket: DH-11625
The internal commit.
I opted to make
QueryTableWouldMatchTestpart of the regular test category as it now runs locally in 7s.I opted to not run nightlies on this change. I did run test coverage locally to ensure that the new
matchoverride was exercised in the new test.