Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for empty ColumnAggregation(s) #3242

Merged

Conversation

devinrsmith
Copy link
Member

Provides better developer experience, see #3235

@devinrsmith devinrsmith added this to the Dec 2022 milestone Dec 26, 2022
@devinrsmith devinrsmith requested a review from niloc132 December 26, 2022 18:11
@devinrsmith devinrsmith self-assigned this Dec 26, 2022
@devinrsmith devinrsmith requested a review from rcaudy December 26, 2022 18:14
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes things better. I'm not sure it fully addresses the developer UX concerns.

@devinrsmith devinrsmith merged commit 845f50d into deephaven:main Jan 11, 2023
@devinrsmith devinrsmith deleted the columns-aggregations-error-message branch January 11, 2023 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants