Port DH-11736: Be more Parsimonious with Chunks during Cross Join #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
query engine
NoDocumentationNeeded
port
ReleaseNotesNeeded
cpwright
approved these changes
Dec 22, 2022
cpwright
reviewed
Dec 22, 2022
| int chunkCapacity = 0; | ||
| // if we had a sort kernel that used bytes as the "index" instead of just ints we could reduce the size of this | ||
| // chunk down to a byte chunk instead of using a full 4 bytes for a 1 byte field | ||
| final SizedIntChunk<Values> flagChunk = new SizedIntChunk<>(); |
There was a problem hiding this comment.
FWIW, "DH-11944: Add support for leftOuterJoin" addresses this TODO.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port was straight forward and I did not need to deviate from the DHE impl.
Nightlies: https://github.com/nbauernfeind/deephaven-core/actions/runs/3753714347/jobs/6377226395
Here are the non-public links:
JIRA: https://deephaven.atlassian.net/browse/DH-11736
DHE Commit: https://gitlab.deephaven.io/illumon/iris/-/commit/c70ae4443b1f4f8464c434b3c98646314497d63d