Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectColumnLayer to only allow cross-column parallelization if its SelectColumn is stateless #3181

Merged
merged 2 commits into from
Dec 11, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ final public class SelectColumnLayer extends SelectOrViewColumnLayer {
// We can only parallelize this column if we are not redirected, our destination provides ensure previous, and
// the select column is stateless
canParallelizeThisColumn = !isRedirected
&& WritableSourceWithPrepareForParallelPopulation.supportsParallelPopulation(ws) && sc.isStateless();
&& WritableSourceWithPrepareForParallelPopulation.supportsParallelPopulation(writableSource)
&& sc.isStateless();

// If we were created on a systemic thread, we want to be sure to make sure that any updates are also
// applied systemically.
Expand Down Expand Up @@ -576,6 +577,6 @@ public LogOutput append(LogOutput logOutput) {

@Override
public boolean allowCrossColumnParallelization() {
return inner.allowCrossColumnParallelization();
return selectColumn.isStateless() && inner.allowCrossColumnParallelization();
}
}