-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dagger mains for better extensibility #3159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Out-of-the-box defaults provides common configuration values, but leaves authorization as an explicit choice for the integrator.
devinrsmith
added
DocumentationNeeded
ReleaseNotesNeeded
Release notes are needed
labels
Dec 28, 2022
devinrsmith
changed the title
WIP: Refactor dagger mains for better extensibility
Refactor dagger mains for better extensibility
Dec 28, 2022
nbauernfeind
reviewed
Jan 4, 2023
server/jetty-app-custom/src/main/java/io/deephaven/server/custom/CustomApplication1.java
Show resolved
Hide resolved
server/jetty-app-custom/src/main/java/io/deephaven/server/custom/CustomApplication2.java
Show resolved
Hide resolved
server/jetty-app-custom/src/main/java/io/deephaven/server/custom/CustomAuthorization.java
Outdated
Show resolved
Hide resolved
nbauernfeind
approved these changes
Jan 4, 2023
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/1997 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves JettyMain from
server-jetty
toserver-jetty-app
; the main class isn't really meant to be a "library". That said, it's a very few short lines of code for integrators to achieve the same thing that JettyMain does:This PR also uses the "Community" prefix in more places to hint to integrators that it may or may not be appropriate for "Enterprise" contexts.
This PR also introduces
server-jetty-app-custom
as an example for how an integrator can customize the structure and configuration of the Deephaven server. It's also useful from the perspective of dogfooding and ensuring DHC developers are aware of any changes that may break integrators.As part of the above,
ComponentFactoryBase
has been added as an abstraction around creating Components. While not technically necessary, it's a useful construct that allows constructing components without callers needing to directly invoke dagger.