DeferredViewTable's filter ordering logic needs to respect view side effects #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
bug
rcaudy
reviewed
Nov 29, 2022
engine/table/src/main/java/io/deephaven/engine/table/impl/select/ConditionFilter.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/AbstractConditionFilter.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/AbstractConditionFilter.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/DeferredViewTable.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/DeferredViewTable.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/DeferredViewTable.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/DeferredViewTable.java
Outdated
Show resolved
Hide resolved
nbauernfeind
force-pushed
the
gh_2701
branch
from
bfbe0cc to
a6818bd
Compare
rcaudy
reviewed
Dec 1, 2022
engine/table/src/main/java/io/deephaven/engine/table/impl/DeferredViewTable.java
Outdated
Show resolved
Hide resolved
rcaudy
approved these changes
Dec 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2701. This fix requires the fix for #1683 in #3120; this fix is the first commit in the PR.
DeferredViewTable was being reckless when looking for column renames. We now look for multiple renames including renames of otherwise deferred columns. Additionally, abstract condition filter was not generating compilable code if two columns were renamed from the same source column. For example,
source.update("A = X", "B = X").where("(A + B).length() > 0")would generate two local variables both namedXin the filter, but still refer to them asAandB. Note thatXin this context is a string -- but the only requirement is that the filter is an abstract condition filter.I've added a few tests to catch both the original issue as well as other similar issues that I discovered during the spelunking process.