Clean up non-compliant code in the query library #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbooker42
changed the title
rcaudy
reviewed
Oct 27, 2022
Co-authored-by: Ryan Caudy <[email protected]>
kosak
reviewed
Oct 27, 2022
kosak
reviewed
Oct 28, 2022
kosak
reviewed
Oct 28, 2022
kosak
previously approved these changes
Oct 28, 2022
chipkent
requested changes
Oct 28, 2022
chipkent
approved these changes
Oct 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
cumMin/cumMaxto match existing functions. Added documentation toforwardFilland disambiguated templated function name.Addresses #3021
Full unit tests for
cummin(),cummax(),forwardfill()functions added with 100% new code coverage