Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jetty images #2945

Merged
merged 5 commits into from
Oct 12, 2022
Merged

Upgrade to Jetty images #2945

merged 5 commits into from
Oct 12, 2022

Conversation

jjbrosnan
Copy link
Contributor

Docker-compose files all share one service. Builds with examples have one additional service, and the redpanda setup has a third image.

I'm not sure if this needs a documentation or NoDocumentationNeeded tag.

@jjbrosnan jjbrosnan added this to the Oct 2022 milestone Oct 4, 2022
@jjbrosnan jjbrosnan self-assigned this Oct 4, 2022
containers/groovy-examples/docker-compose.yml Outdated Show resolved Hide resolved
containers/groovy-examples/docker-compose.yml Outdated Show resolved Hide resolved
@devinrsmith
Copy link
Member

I think DocumentationNeeded is appropriate. We'll want to update deephaven.io as appropriate.

@jjbrosnan jjbrosnan requested a review from niloc132 October 4, 2022 18:18
@jjbrosnan
Copy link
Contributor Author

I just re-tested all deployments (w/ and w/o examples, python, groovy) and had no issues. This PR should be ready for merge.

@jjbrosnan jjbrosnan requested a review from devinrsmith October 12, 2022 12:13
@jjbrosnan jjbrosnan merged commit 9034a48 into deephaven:main Oct 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2022
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

How-to: https://github.com/deephaven/deephaven.io/issues/1775
Conceptual: https://github.com/deephaven/deephaven.io/issues/1773
Reference: https://github.com/deephaven/deephaven.io/issues/1774
Blog: Failed to create issue: HttpError: invalid json response body at https://api.github.com/repos/deephaven/deephaven.io/issues reason: Unexpected end of JSON input

@jjbrosnan jjbrosnan deleted the update-to-jetty branch August 1, 2023 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants