Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address integer overflow in static NJ and AJ; clean up wider-than-necessary type usage and eliminate legacy chunked hashers in NJ and AJ #2906

Merged
merged 3 commits into from
Sep 25, 2022
Merged

Address integer overflow in static NJ and AJ; clean up wider-than-necessary type usage and eliminate legacy chunked hashers in NJ and AJ #2906

merged 3 commits into from
Sep 25, 2022

Conversation

rcaudy
Copy link
Member

@rcaudy rcaudy commented Sep 25, 2022 •
edited
Loading

FIxes #2897

  1. Eliminate legacy chunked natural join state managers and clean up code accordingly.
  2. Fix position overflow bug in left hash slots/redirections gathering during natural join instantiation.
  3. Switch to a narrower type for hash slot gathering in NJ, since we no longer need space for overflow masking.
  4. Eliminate legacy chunked as-of join state managers and clean up code accordingly.
  5. Fix position overflow bug in left hash slots/redirections gathering during as-of join instantiation.
  6. Switch to a narrower type for hash slot gathering in AJ since we no longer need space for overflow masking.
  7. Finish deleting the IncrementalChunkedNaturalJoinStateManager and making a few more long->int conversions for NJ.

@rcaudy
1. Eliminate legacy chunked natural join state managers and clean up …
9902dd0 
…code accordingly.

2. Fix position overflow bug in left hash slots/redirections gathering during natural join instantiation.
3. Switch to a narrower type for hash slot gathering, since we no longer need space for overflow masking.
@rcaudy
1. Eliminate legacy chunked as-of join state managers and clean up co…
6ff6625 
…de accordingly.

2. Fix position overflow bug in left hash slots/redirections gathering during as-of join instantiation.
3. Switch to a narrower type for hash slot gathering in AJ since we no longer need space for overflow masking.
4. Finish deleting the IncrementalChunkedNaturalJoinStateManager and making a few more long->int conversions for NJ.
@rcaudy
Spotless
f709e17
@rcaudy rcaudy added this to the Sept 2022 milestone Sep 25, 2022
@rcaudy rcaudy self-assigned this Sep 25, 2022
@rcaudy
Copy link
Member Author

rcaudy commented Sep 25, 2022

Nightlies are passing with the changes.

@rcaudy rcaudy merged commit c129992 into deephaven:main Sep 25, 2022
@rcaudy rcaudy deleted the rwc-njajoverflowfix branch September 25, 2022 14:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpwright cpwright cpwright approved these changes

@lbooker42 lbooker42 Awaiting requested review from lbooker42

Assignees

@rcaudy rcaudy

Labels
bug Something isn't working NoDocumentationNeeded query engine
Projects
None yet
Milestone
Sept 2022
Development

Successfully merging this pull request may close these issues.

NullPointerException in natural_join
2 participants
@rcaudy @cpwright