Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a vectorized ternary if to the query library. #2876

Merged
merged 4 commits into from
Sep 20, 2022
Merged

Add a vectorized ternary if to the query library. #2876

merged 4 commits into from
Sep 20, 2022

Conversation

chipkent
Copy link
Member

Adds a vectorized ternary-if the query library.

Fixes #2875 .

@chipkent chipkent added this to the Sept 2022 milestone Sep 19, 2022
@chipkent chipkent requested a review from kosak September 19, 2022 19:07
@chipkent chipkent self-assigned this Sep 19, 2022
kosak
kosak reviewed Sep 19, 2022
View reviewed changes
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Show resolved Hide resolved
@chipkent chipkent requested a review from kosak September 19, 2022 21:54
kosak
kosak previously approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@kosak kosak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with one wording suggestion and some whitespace nits.

engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
@chipkent chipkent requested a review from kosak September 19, 2022 22:04
@chipkent chipkent merged commit 1233561 into deephaven:main Sep 20, 2022
@chipkent chipkent deleted the query_lib_ternary_if branch September 20, 2022 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kosak kosak kosak approved these changes

Assignees

@chipkent chipkent

Labels
DocumentationNeeded
Projects
None yet
Milestone
Sept 2022
Development

Successfully merging this pull request may close these issues.

Add a vectorized ternary-if the the query library
2 participants
@chipkent @kosak