Remove java execution logic during table.py module init #2872
Conversation
…ead which java takes care of
|
Related #2867 |
py/server/tests/test_filters.py
Outdated
| @@ -11,10 +11,12 @@ | |||
|
|
|||
| class FilterTestCase(BaseTestCase): | |||
| def setUp(self): | |||
| BaseTestCase.setUp(self) | |||
py/server/deephaven/table.py
Outdated
| if not j_query_scope: | ||
| raise DHError("ExecutionContext does not have QueryScope") |
There was a problem hiding this comment.
check for PoisonedQueryScope?
There was a problem hiding this comment.
The following cast will throw an appropriate exception, essentially saying that a poisoned query scope can't be cast into the type we are wanting to.
There was a problem hiding this comment.
That said; this may have been me fumbling around trying to figure out why my DHError wasn't working. Looking at the code, I don't think any of the values in ExecutionContext can/should be null. I'll add a not null check to ExecutionContext, and I think we can get rid of this extraneous check.
py/server/tests/test_table.py
Outdated
|
|
||
| t = empty_table(1).update("X = i").update("TableString = inner_func(X + 10)") | ||
| with make_user_exec_ctx(): | ||
| def inner_func(p) -> str: |
There was a problem hiding this comment.
I feel that it is more clear if the method is not defined within the open context. Only the update calls need it.
py/server/tests/test_table.py
Outdated
| open_ctx.close() | ||
| return t.to_string().split()[2] | ||
| with make_user_exec_ctx(): | ||
| def inner_func(p) -> str: |
There was a problem hiding this comment.
same on this inner function
|
LGTM, too (yah, I know it's already merged) |
Fixes #2853