Make DeephavenSessionTestBase use NoLanguageDeephavenSession #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
force-pushed
the
annotated_table_test_oob
branch
from
37812a9 to
7b4570a
Compare
nbauernfeind
changed the title
nbauernfeind
force-pushed
the
annotated_table_test_oob
branch
from
7b4570a to
92f7c51
Compare
nbauernfeind
force-pushed
the
annotated_table_test_oob
branch
from
92f7c51 to
b0877e0
Compare
devinrsmith
reviewed
Sep 7, 2022
server/src/test/java/io/deephaven/server/runner/DeephavenApiServerTestBase.java
Outdated
Show resolved
Hide resolved
server/jetty/src/test/java/io/deephaven/server/jetty/JettyFlightRoundTripTest.java
Outdated
Show resolved
Hide resolved
nbauernfeind
force-pushed
the
annotated_table_test_oob
branch
from
0c28f1a to
ff4bcbe
Compare
devinrsmith
approved these changes
Sep 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnnotatedTableTestbegan to take ~20m to execute after the ExecutionContext merge. Groovy sessions were running their init scripts and many tests required a query compilation as no results were being cached. It now runs all 968 tests within 10-20s (back to where it originally was).