Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow Flight Auth 1 and 2 #2713

Merged
merged 5 commits into from
Sep 6, 2022
Merged

Arrow Flight Auth 1 and 2 #2713

merged 5 commits into from
Sep 6, 2022

Conversation

nbauernfeind
Copy link
Member

@nbauernfeind nbauernfeind commented Aug 4, 2022 •
edited
Loading

We're moving away from SessionService::newSession to Flight Auth. This leaves the javascript side alone, but otherwise enables flight based auth server side.

Fixes #997.

@nbauernfeind nbauernfeind added this to the Aug 2022 milestone Aug 4, 2022
@nbauernfeind nbauernfeind requested a review from niloc132 August 4, 2022 17:11
@nbauernfeind nbauernfeind self-assigned this Aug 4, 2022
niloc132
niloc132 reviewed Aug 5, 2022
View reviewed changes
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main thing I don't see is how to handle multi-step auth, how the server would say "okay here's a nonce to sign" or something using ... errors from the Authorization header or Handshake() call

authentication/README.md Outdated Show resolved Hide resolved
Util/src/main/java/io/deephaven/util/auth/AuthContext.java Outdated Show resolved Hide resolved
authentication/src/main/java/io/deephaven/auth/AuthenticationRequestHandler.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/auth/AuthContextModule.java Show resolved Hide resolved
server/src/main/java/io/deephaven/server/auth/AuthContextModule.java Outdated Show resolved Hide resolved
py/client/pydeephaven/session.py Show resolved Hide resolved
server/src/main/java/io/deephaven/server/auth/TrivialAuthContextProvider.java Outdated Show resolved Hide resolved
authentication/src/main/java/io/deephaven/auth/AuthenticationRequestHandler.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/arrow/FlightServiceGrpcImpl.java Show resolved Hide resolved
server/src/main/java/io/deephaven/server/arrow/FlightServiceGrpcImpl.java Outdated Show resolved Hide resolved
@nbauernfeind nbauernfeind modified the milestones: Aug 2022, Sept 2022 Sep 4, 2022
@nbauernfeind nbauernfeind merged commit d0cba48 into deephaven:main Sep 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niloc132 niloc132 niloc132 approved these changes

Assignees

@nbauernfeind nbauernfeind

Labels
arrow barrage DocumentationNeeded
Projects
None yet
Milestone
Sept 2022
Development

Successfully merging this pull request may close these issues.

integrate with flight auth
2 participants
@nbauernfeind @niloc132