LazyUpdateTable #2699
Merged
LazyUpdateTable #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rcaudy
approved these changes
Jul 29, 2022
| @@ -51,8 +51,13 @@ public TableSpec apply(TableSpec spec, String[] formulas) { | |||
| public TableSpec apply(TableSpec spec, String[] formulas) { | |||
| return spec.select(formulas); | |||
| } | |||
| }, | |||
| LAZY_UPDATE { | |||
There was a problem hiding this comment.
This creates a conflict with your other PR, but you probably know that.
There was a problem hiding this comment.
Yep. I'm hoping to get #2635 merged in first, will fix conflicts here.
| @@ -166,6 +166,12 @@ | |||
|
|
|||
| // ------------------------------------------------------------------------------------------- | |||
|
|
|||
| TOPS lazyUpdate(String... columns); | |||
There was a problem hiding this comment.
This reminds me that JavaDoc should really make its way up to TableOperations, but not necessarily in this PR. I think table-api will never become a tool for new users without that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial #711