Add support for local arm64 builds #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
added
feature request
|
Note: I did not pull over the protoc (now, protoc-base in deephaven-base-images) changes after short chat with Colin that it's was mainly a build speed issues (M1 can emulate running AMD64 protoc-base), nor the Parquet configuration change. |
niloc132
reviewed
Dec 15, 2021
buildSrc/src/main/groovy/io/deephaven/tools/docker/Architecture.groovy
Outdated
Show resolved
Hide resolved
niloc132
reviewed
Dec 15, 2021
Follow up deephaven#1702 Follow up deephaven#1703
devinrsmith
force-pushed
the
build/docker/arch
branch
from
ca5be90 to
f13ca94
Compare
niloc132
approved these changes
Dec 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rcaudy has tested CLI and IJ