Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS API marks a table as coalesced after it has been subscribed to, even if it isn't #6210

Closed
niloc132 opened this issue Oct 17, 2024 · 0 comments · Fixed by #6211
Closed

JS API marks a table as coalesced after it has been subscribed to, even if it isn't #6210

niloc132 opened this issue Oct 17, 2024 · 0 comments · Fixed by #6211
Assignees
@niloc132
Labels
bug Something isn't working javascript Pull requests that update Javascript code jsapi release blocker A bug/behavior that puts is below the "good enough" threshold to release. triage
Milestone
0.37.0

Comments

@niloc132
Copy link
Member

When the JS API fetches an uncoalesced table, it records the size as Long.MIN_VALUE. When a table has a viewport subscription on it, the table's own size is overwritten with the current size of the table. Historically, this size was sent to another table instance (reflecting the fact that the table was flattened before subscribing), and if the table was still subscribed, it would delegate any size calls to that instance.

The JS Flight refactor incorrectly removed that delegation, so now after an uncoalesced table has been subscribed, it will no longer be marked as uncoalesced.
@niloc132 niloc132 added bug Something isn't working jsapi triage release blocker A bug/behavior that puts is below the "good enough" threshold to release. javascript Pull requests that update Javascript code labels Oct 17, 2024
@niloc132 niloc132 added this to the 0.37.0 milestone Oct 17, 2024
@niloc132 niloc132 self-assigned this Oct 17, 2024
niloc132 added a commit to niloc132/deephaven-core that referenced this issue Oct 18, 2024
@niloc132
fix: Subscribing to an uncoalesced table must not make it seem coalesced
ff0141f 
Fixes deephaven#6210
@niloc132 niloc132 mentioned this issue Oct 18, 2024
Merged
@mofojed mofojed mentioned this issue Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloc132 niloc132

Labels
bug Something isn't working javascript Pull requests that update Javascript code jsapi release blocker A bug/behavior that puts is below the "good enough" threshold to release. triage
Projects
None yet
Milestone
0.37.0
Development

Successfully merging a pull request may close this issue.

fix: Subscribing to an uncoalesced table must not make it seem coalesced niloc132/deephaven-core
1 participant
@niloc132