Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsapi: Web-Client Quick Filter Sees Null Values #6138

Closed
nbauernfeind opened this issue Sep 26, 2024 · 1 comment · Fixed by #6148
Closed

jsapi: Web-Client Quick Filter Sees Null Values #6138

nbauernfeind opened this issue Sep 26, 2024 · 1 comment · Fixed by #6148
Assignees
Labels
barrage bug Something isn't working jsapi release blocker A bug/behavior that puts is below the "good enough" threshold to release. web-client-ui The Web GUI
Milestone

Comments

@nbauernfeind
Copy link
Member

This is not a web-client issue, I've confirmed that it was introduced in #5890.

Run this query:

t = timeTable("PT1s").update("Timestamp = Timestamp.toString()")

Then try to quick filter from the UI on any row after the first two. (which happen to work 🤷)

Screenshot 2024-09-25 at 11 07 02 PM Screenshot 2024-09-25 at 11 07 07 PM
@nbauernfeind nbauernfeind added bug Something isn't working web-client-ui The Web GUI jsapi barrage labels Sep 26, 2024
@nbauernfeind nbauernfeind added this to the 0.37.0 milestone Sep 26, 2024
@nbauernfeind nbauernfeind added the release blocker A bug/behavior that puts is below the "good enough" threshold to release. label Sep 26, 2024
@mofojed
Copy link
Member

mofojed commented Sep 26, 2024

Seems to be UI is getting an empty snapshot. Can reproduce with an empty_table, and in the JSAPI page browser console (http://localhost:10000/jsapi/):

console.log('Creating connection....')
var dh = (await import('./dh-core.js')).default
var client = new dh.CoreClient(window.location.protocol + "//" + window.location.host);
await client.login({ type: dh.CoreClient.LOGIN_TYPE_ANONYMOUS });
var connection = await client.getAsIdeConnection();
var ide = await connection.startSession('python')
await ide.runCode(`
from deephaven import time_table
t = empty_table(100).update("x=\`\`+i")
`)
var t = await ide.getTable('t')
var subscription = t.setViewport(0, 100, t.columns)
console.log('t.size=', t.size);
var snapshot0 = await subscription.snapshot(dh.RangeSet.ofRange(0,0), t.columns);
console.log('snapshot0.rows=', snapshot0.rows)
var snapshot2 = await subscription.snapshot(dh.RangeSet.ofRange(2,2), t.columns);
console.log('snapshot2.rows=', snapshot2.rows)

niloc132 added a commit to niloc132/deephaven-core that referenced this issue Sep 27, 2024
Also fixed an error when the table (or viewport) is empty.

Fixes deephaven#6138
niloc132 added a commit to niloc132/deephaven-core that referenced this issue Sep 27, 2024
Also fixed an error when the table (or viewport) is empty.

Fixes deephaven#6138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
barrage bug Something isn't working jsapi release blocker A bug/behavior that puts is below the "good enough" threshold to release. web-client-ui The Web GUI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants