-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dremio odbc interpretation of flight auth #5922
Comments
niloc132
added a commit
to niloc132/deephaven-core
that referenced
this issue
Aug 15, 2024
The Go client required sending v2 auth, but receiving v1 responses - this change makes it consistently use v1 auth. The JS client incorrectly closed the stream only after it had received headers - now it can close right away, and just wait for headers to arrive normally. Prerequisite to deephaven#5922
niloc132
added a commit
that referenced
this issue
Aug 16, 2024
The Go client required sending v2 auth, but receiving v1 responses - this change makes it consistently use v1 auth. The JS client incorrectly closed the stream only after it had received headers - now it can close right away, and just wait for headers to arrive normally. Prerequisite to #5922
niloc132
added a commit
to niloc132/deephaven-core
that referenced
this issue
Aug 16, 2024
The Go client required sending v2 auth, but receiving v1 responses - this change makes it consistently use v1 auth. The JS client incorrectly closed the stream only after it had received headers - now it can close right away, and just wait for headers to arrive normally. Prerequisite to deephaven#5922
niloc132
added a commit
that referenced
this issue
Oct 8, 2024
Handshake calls previously required the client to send at least one message before sending a response, even if the required auth information was included in headers, now the server will respond and close the stream right away. This change could cause problems for older DH clients (specifically JS and Go clients), but the fix for this was released in 0.36. Bearer authentication would fail if the token wasn't in the form of a UUID, even if an alternative authentication handler was going to accept the token. Some Flight clients are unable to send auth types other than Basic and Bearer, our authentication interceptor can now support the auth type as a space-separated prefix of the auth token. Fixes #5922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Three bugs found while working with alternative Flight clients:
The text was updated successfully, but these errors were encountered: