Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: coerce invalid Iceberg schema column names to valid Deephaven names #5714

Closed
lbooker42 opened this issue Jul 3, 2024 · 0 comments · Fixed by #5746
Closed

feat: coerce invalid Iceberg schema column names to valid Deephaven names #5714

lbooker42 opened this issue Jul 3, 2024 · 0 comments · Fixed by #5746
Assignees
@lbooker42
Labels
feature request New feature or request triage
Milestone
0.36.0

Comments

@lbooker42
Copy link
Contributor

Use io.deephaven.api.util.NameValidator#legalizeColumnName(java.lang.String, java.util.function.Function<java.lang.String,java.lang.String>, java.util.Set<java.lang.String>) to coerce Iceberg Schema column names to valid Deephaven column names similar to how it is done in Parquet schema processing.
@lbooker42 lbooker42 added feature request New feature or request triage labels Jul 3, 2024
@lbooker42 lbooker42 added this to the 0.36.0 milestone Jul 3, 2024
@lbooker42 lbooker42 self-assigned this Jul 3, 2024
@lbooker42 lbooker42 mentioned this issue Jul 9, 2024
Merged
lbooker42 added a commit to lbooker42/deephaven-core that referenced this issue Jul 19, 2024
@lbooker42
feat: Add auto-legalization for Iceberg Schema column names. (deephav…
0d864f4 
…en#5746)

Will close deephaven#5714 when merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbooker42 lbooker42

Labels
feature request New feature or request triage
Projects
None yet
Milestone
0.36.0
Development

Successfully merging a pull request may close this issue.

feat: Add auto-legalization for Iceberg Schema column names. lbooker42/deephaven-core
1 participant
@lbooker42