Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplication for suggested defaults for java VM options #3054

Closed
devinrsmith opened this issue Nov 2, 2022 · 0 comments · Fixed by #3057
Closed

Reduce duplication for suggested defaults for java VM options #3054

devinrsmith opened this issue Nov 2, 2022 · 0 comments · Fixed by #3057
Assignees
@devinrsmith
Labels
configuration feature request New feature or request triage
Milestone
Backlog

Comments

@devinrsmith
Copy link
Member

Currently, our recommended defaults "-XX:+UseG1GC -XX:MaxGCPauseMillis=100 -XX:+UseStringDeduplication".

Follow-up to #3009

May be worthwhile to add a new file into our .tar distribution (like we do for compiler directives), and potentially use -XX:VMOptionsFile=filename.
@devinrsmith devinrsmith added feature request New feature or request triage labels Nov 2, 2022
@devinrsmith devinrsmith added this to the Backlog milestone Nov 2, 2022
@devinrsmith devinrsmith self-assigned this Nov 2, 2022
@devinrsmith devinrsmith mentioned this issue Nov 2, 2022
Merged
devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Nov 2, 2022
@devinrsmith
Add dh-defaults.vmoptions file
56138fe 
Consolidates the recommended VM options into a single place. Allows for these options to be defined in a single place.

Moves dh-compiler-directives.txt and dh-defaults.vmoptions into the etc directory (instead of in lib alongside the jars).

Fixes deephaven#3054
@devinrsmith devinrsmith mentioned this issue Nov 2, 2022
Merged
devinrsmith added a commit that referenced this issue Dec 1, 2022
@devinrsmith
Add dh-defaults.vmoptions file (#3057)
106bdf8 
Consolidates the recommended VM options into a single place. Allows for these options to be defined in a single place.

Moves dh-compiler-directives.txt and dh-defaults.vmoptions into the etc directory (instead of in lib alongside the jars).

Fixes #3054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devinrsmith devinrsmith

Labels
configuration feature request New feature or request triage
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add dh-defaults.vmoptions file devinrsmith/deephaven-core
1 participant
@devinrsmith