Skip to content

Commit

Permalink
Remove -netty and related image publishing (#3027)
Browse files Browse the repository at this point in the history
It probably makes sense to remove most of these jobs and underlying gradle tasks in a more thorough cleanup.

The one part that makes sense to keep is any necessary crane retagging, such as with protoc-base.
  • Loading branch information
devinrsmith authored Oct 26, 2022
1 parent 9c10cfe commit 700511b
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions .github/workflows/build-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ jobs:
tags: ${{ steps.docker_meta_server.outputs.tags }}
builder: ${{ steps.buildx.outputs.name }}
context: ./docker/server/build/context/
push: ${{ github.event_name != 'pull_request' }}
push: false

- name: Docker build server nltk
uses: docker/build-push-action@v2
Expand All @@ -196,7 +196,7 @@ jobs:
tags: ${{ steps.docker_meta_server_nltk.outputs.tags }}
builder: ${{ steps.buildx.outputs.name }}
context: ./docker/server/build/context/
push: ${{ github.event_name != 'pull_request' }}
push: false

- name: Docker build server pytorch
uses: docker/build-push-action@v2
Expand All @@ -208,7 +208,7 @@ jobs:
tags: ${{ steps.docker_meta_server_pytorch.outputs.tags }}
builder: ${{ steps.buildx.outputs.name }}
context: ./docker/server/build/context/
push: ${{ github.event_name != 'pull_request' }}
push: false

- name: Docker build server sklearn
uses: docker/build-push-action@v2
Expand All @@ -220,7 +220,7 @@ jobs:
tags: ${{ steps.docker_meta_server_sklearn.outputs.tags }}
builder: ${{ steps.buildx.outputs.name }}
context: ./docker/server/build/context/
push: ${{ github.event_name != 'pull_request' }}
push: false

- name: Docker build server tensorflow
uses: docker/build-push-action@v2
Expand All @@ -232,7 +232,7 @@ jobs:
tags: ${{ steps.docker_meta_server_tensorflow.outputs.tags }}
builder: ${{ steps.buildx.outputs.name }}
context: ./docker/server/build/context/
push: ${{ github.event_name != 'pull_request' }}
push: false

- name: Docker build server all-ai
uses: docker/build-push-action@v2
Expand All @@ -244,7 +244,7 @@ jobs:
tags: ${{ steps.docker_meta_server_all_ai.outputs.tags }}
builder: ${{ steps.buildx.outputs.name }}
context: ./docker/server/build/context/
push: ${{ github.event_name != 'pull_request' }}
push: false

# Note: server-slim does not need BASE/SERVER build-args like the other server images
- name: Docker build server slim
Expand All @@ -255,7 +255,7 @@ jobs:
tags: ${{ steps.docker_meta_server_slim.outputs.tags }}
builder: ${{ steps.buildx.outputs.name }}
context: ./docker/server-slim/build/context/
push: ${{ github.event_name != 'pull_request' }}
push: false

- name: Tag upstream images
if: ${{ startsWith(github.ref, 'refs/heads/release/v') }}
Expand Down Expand Up @@ -354,7 +354,7 @@ jobs:
tags: ${{ steps.docker_meta.outputs.tags }}
builder: ${{ steps.buildx.outputs.name }}
context: ./grpc-proxy/build/docker/
push: ${{ github.event_name != 'pull_request' }}
push: false

envoy:
runs-on: ubuntu-22.04
Expand Down Expand Up @@ -441,7 +441,7 @@ jobs:
tags: ${{ steps.docker_meta.outputs.tags }}
builder: ${{ steps.buildx.outputs.name }}
context: ./envoy/build/docker/
push: ${{ github.event_name != 'pull_request' }}
push: false

web:
runs-on: ubuntu-22.04
Expand Down Expand Up @@ -532,7 +532,7 @@ jobs:
tags: ${{ steps.docker_meta.outputs.tags }}
builder: ${{ steps.buildx.outputs.name }}
context: ./docker/web/build/docker/
push: ${{ github.event_name != 'pull_request' }}
push: false

- name: Tag upstream images
if: ${{ startsWith(github.ref, 'refs/heads/release/v') }}
Expand Down Expand Up @@ -617,7 +617,7 @@ jobs:
tags: ${{ steps.docker_meta.outputs.tags }}
builder: ${{ steps.buildx.outputs.name }}
context: ./docker/web-plugin-packager/build/context/
push: ${{ github.event_name != 'pull_request' }}
push: false

### Notes about `driver: docker`
###
Expand Down

0 comments on commit 700511b

Please sign in to comment.