Remove TTS WS Implementation from main
#433
Conversation
WalkthroughThe overall change involves commenting out functionality related to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
davidvonthenen
changed the title
main
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- deepgram/init.py (2 hunks)
- deepgram/client.py (2 hunks)
- deepgram/clients/init.py (2 hunks)
- deepgram/clients/speak/init.py (1 hunks)
- deepgram/clients/speak/client.py (3 hunks)
- deepgram/clients/speak/v1/init.py (1 hunks)
Files skipped from review due to trivial changes (1)
- deepgram/client.py
Additional context used
Learnings (5)
deepgram/clients/speak/__init__.py (9)
Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/__init__.py:16-19 Timestamp: 2024-07-01T19:12:57.715Z Learning: Unused imports in `deepgram/clients/speak/__init__.py` are retained for backward compatibility and should not be flagged for removal in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/v1/websocket/__init__.py:11-11 Timestamp: 2024-07-01T19:14:53.172Z Learning: User dvonthenen prefers to retain unused imports in the codebase to maintain backward compatibility.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/v1/websocket/__init__.py:14-14 Timestamp: 2024-07-01T19:14:41.918Z Learning: User dvonthenen prefers to retain unused imports in the codebase to maintain backward compatibility.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/listen/v1/websocket/__init__.py:8-8 Timestamp: 2024-07-01T19:21:39.778Z Learning: Unused imports in `deepgram/clients/listen/v1/websocket/__init__.py` are retained to maintain backward compatibility and should not be flagged for removal in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/v1/websocket/__init__.py:10-10 Timestamp: 2024-07-01T19:14:59.869Z Learning: User dvonthenen prefers to retain unused imports in the codebase to maintain backward compatibility, even if they are flagged as unused.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#424 File: deepgram/client.py:81-81 Timestamp: 2024-06-27T00:06:01.811Z Learning: Imports for SpeakStreamClient and AsyncSpeakStreamClient in `deepgram/client.py` are necessary for export purposes and should not be flagged as unused in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/listen/__init__.py:42-50 Timestamp: 2024-07-01T19:13:28.504Z Learning: Unused imports in `deepgram/clients/listen/__init__.py` are retained to maintain backward compatibility and should not be flagged for removal in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/listen/__init__.py:19-24 Timestamp: 2024-07-01T19:14:20.539Z Learning: Unused imports in `deepgram/clients/listen/__init__.py` are retained to maintain backward compatibility and should not be flagged for removal in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/listen/v1/__init__.py:36-43 Timestamp: 2024-07-01T19:17:04.194Z Learning: Unused imports in `deepgram/clients/listen/v1/__init__.py` are retained to maintain backward compatibility and should not be flagged for removal in reviews.deepgram/clients/speak/v1/__init__.py (10)
Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/__init__.py:16-19 Timestamp: 2024-07-01T19:12:57.715Z Learning: Unused imports in `deepgram/clients/speak/__init__.py` are retained for backward compatibility and should not be flagged for removal in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/v1/websocket/__init__.py:11-11 Timestamp: 2024-07-01T19:14:53.172Z Learning: User dvonthenen prefers to retain unused imports in the codebase to maintain backward compatibility.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/v1/websocket/__init__.py:14-14 Timestamp: 2024-07-01T19:14:41.918Z Learning: User dvonthenen prefers to retain unused imports in the codebase to maintain backward compatibility.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/v1/websocket/__init__.py:10-10 Timestamp: 2024-07-01T19:14:59.869Z Learning: User dvonthenen prefers to retain unused imports in the codebase to maintain backward compatibility, even if they are flagged as unused.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/listen/v1/websocket/__init__.py:8-8 Timestamp: 2024-07-01T19:21:39.778Z Learning: Unused imports in `deepgram/clients/listen/v1/websocket/__init__.py` are retained to maintain backward compatibility and should not be flagged for removal in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/listen/v1/__init__.py:36-43 Timestamp: 2024-07-01T19:17:04.194Z Learning: Unused imports in `deepgram/clients/listen/v1/__init__.py` are retained to maintain backward compatibility and should not be flagged for removal in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#424 File: deepgram/client.py:81-81 Timestamp: 2024-06-27T00:06:01.811Z Learning: Imports for SpeakStreamClient and AsyncSpeakStreamClient in `deepgram/client.py` are necessary for export purposes and should not be flagged as unused in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/listen/__init__.py:42-50 Timestamp: 2024-07-01T19:13:28.504Z Learning: Unused imports in `deepgram/clients/listen/__init__.py` are retained to maintain backward compatibility and should not be flagged for removal in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/listen/__init__.py:19-24 Timestamp: 2024-07-01T19:14:20.539Z Learning: Unused imports in `deepgram/clients/listen/__init__.py` are retained to maintain backward compatibility and should not be flagged for removal in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#431 File: deepgram/clients/listen/v1/websocket/client.py:30-30 Timestamp: 2024-07-11T14:10:17.231Z Learning: The `LiveOptions` import in `deepgram/clients/listen/v1/websocket/client.py` is intentionally present for future use and should not be flagged for removal in reviews.deepgram/clients/speak/client.py (6)
Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/__init__.py:16-19 Timestamp: 2024-07-01T19:12:57.715Z Learning: Unused imports in `deepgram/clients/speak/__init__.py` are retained for backward compatibility and should not be flagged for removal in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/v1/websocket/__init__.py:11-11 Timestamp: 2024-07-01T19:14:53.172Z Learning: User dvonthenen prefers to retain unused imports in the codebase to maintain backward compatibility.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/v1/websocket/__init__.py:14-14 Timestamp: 2024-07-01T19:14:41.918Z Learning: User dvonthenen prefers to retain unused imports in the codebase to maintain backward compatibility.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/v1/websocket/__init__.py:10-10 Timestamp: 2024-07-01T19:14:59.869Z Learning: User dvonthenen prefers to retain unused imports in the codebase to maintain backward compatibility, even if they are flagged as unused.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/listen/v1/websocket/__init__.py:8-8 Timestamp: 2024-07-01T19:21:39.778Z Learning: Unused imports in `deepgram/clients/listen/v1/websocket/__init__.py` are retained to maintain backward compatibility and should not be flagged for removal in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#424 File: deepgram/client.py:81-81 Timestamp: 2024-06-27T00:06:01.811Z Learning: Imports for SpeakStreamClient and AsyncSpeakStreamClient in `deepgram/client.py` are necessary for export purposes and should not be flagged as unused in reviews.deepgram/clients/__init__.py (6)
Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/__init__.py:16-19 Timestamp: 2024-07-01T19:12:57.715Z Learning: Unused imports in `deepgram/clients/speak/__init__.py` are retained for backward compatibility and should not be flagged for removal in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/v1/websocket/__init__.py:11-11 Timestamp: 2024-07-01T19:14:53.172Z Learning: User dvonthenen prefers to retain unused imports in the codebase to maintain backward compatibility.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/v1/websocket/__init__.py:14-14 Timestamp: 2024-07-01T19:14:41.918Z Learning: User dvonthenen prefers to retain unused imports in the codebase to maintain backward compatibility.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/v1/websocket/__init__.py:10-10 Timestamp: 2024-07-01T19:14:59.869Z Learning: User dvonthenen prefers to retain unused imports in the codebase to maintain backward compatibility, even if they are flagged as unused.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/listen/v1/websocket/__init__.py:8-8 Timestamp: 2024-07-01T19:21:39.778Z Learning: Unused imports in `deepgram/clients/listen/v1/websocket/__init__.py` are retained to maintain backward compatibility and should not be flagged for removal in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#431 File: deepgram/clients/listen/v1/websocket/client.py:30-30 Timestamp: 2024-07-11T14:10:17.231Z Learning: The `LiveOptions` import in `deepgram/clients/listen/v1/websocket/client.py` is intentionally present for future use and should not be flagged for removal in reviews.deepgram/__init__.py (6)
Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/v1/websocket/__init__.py:10-10 Timestamp: 2024-07-01T19:14:59.869Z Learning: User dvonthenen prefers to retain unused imports in the codebase to maintain backward compatibility, even if they are flagged as unused.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/v1/websocket/__init__.py:11-11 Timestamp: 2024-07-01T19:14:53.172Z Learning: User dvonthenen prefers to retain unused imports in the codebase to maintain backward compatibility.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/v1/websocket/__init__.py:14-14 Timestamp: 2024-07-01T19:14:41.918Z Learning: User dvonthenen prefers to retain unused imports in the codebase to maintain backward compatibility.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/speak/__init__.py:16-19 Timestamp: 2024-07-01T19:12:57.715Z Learning: Unused imports in `deepgram/clients/speak/__init__.py` are retained for backward compatibility and should not be flagged for removal in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#426 File: deepgram/clients/listen/v1/websocket/__init__.py:8-8 Timestamp: 2024-07-01T19:21:39.778Z Learning: Unused imports in `deepgram/clients/listen/v1/websocket/__init__.py` are retained to maintain backward compatibility and should not be flagged for removal in reviews.Learnt from: dvonthenen PR: deepgram/deepgram-python-sdk#431 File: deepgram/clients/listen/v1/websocket/client.py:30-30 Timestamp: 2024-07-11T14:10:17.231Z Learning: The `LiveOptions` import in `deepgram/clients/listen/v1/websocket/client.py` is intentionally present for future use and should not be flagged for removal in reviews.
Ruff
deepgram/clients/speak/__init__.py
16-16:
.client.SpeakOptionsimported but unused; consider removing, adding to__all__, or using a redundant alias(F401)
17-17:
.client.SpeakRESTOptionsimported but unused; consider removing, adding to__all__, or using a redundant alias(F401)
19-19:
.client.FileSourceimported but unused; consider removing, adding to__all__, or using a redundant alias(F401)
20-20:
.client.SpeakRestSourceimported but unused; consider removing, adding to__all__, or using a redundant alias(F401)
21-21:
.client.SpeakSourceimported but unused; consider removing, adding to__all__, or using a redundant alias(F401)
24-24:
.client.SpeakResponseimported but unused; consider removing, adding to__all__, or using a redundant alias(F401)
25-25:
.client.SpeakRESTResponseimported but unused; consider removing, adding to__all__, or using a redundant alias(F401)
deepgram/clients/speak/v1/__init__.py
18-18:
....options.DeepgramClientOptionsimported but unused; consider removing, adding to__all__, or using a redundant alias(F401)
18-18:
....options.ClientOptionsFromEnvimported but unused; consider removing, adding to__all__, or using a redundant alias(F401)
21-21:
.rest.SpeakRESTClientimported but unused; consider removing, adding to__all__, or using a redundant alias(F401)
21-21:
.rest.AsyncSpeakRESTClientimported but unused; consider removing, adding to__all__, or using a redundant alias(F401)
23-23:
.rest.SpeakRESTResponseimported but unused; consider removing, adding to__all__, or using a redundant alias(F401)
Additional comments not posted (15)
deepgram/clients/speak/__init__.py (3)
12-13: Commented out WebSocket client imports.The imports for
SpeakWebSocketClientandAsyncSpeakWebSocketClienthave been commented out. This aligns with the PR's objective to temporarily remove the TTS WebSocket implementation.
18-18: Commented out WebSocket options import.The import for
SpeakWebSocketOptionshas been commented out, consistent with the removal of the TTS WebSocket implementation.
26-33: Commented out WebSocket response imports.The imports for various WebSocket response types have been commented out. This is consistent with the temporary removal of the TTS WebSocket functionality.
deepgram/clients/speak/v1/__init__.py (2)
15-17: Commented out WebSocket options imports.The imports for
SpeakWebSocketOptionshave been commented out, consistent with the removal of the TTS WebSocket implementation.
25-36: Commented out WebSocket client and response imports.The imports for
SpeakWebSocketClient,AsyncSpeakWebSocketClient, and various WebSocket response types have been commented out. This aligns with the PR's objective to temporarily remove the TTS WebSocket implementation.deepgram/clients/speak/client.py (6)
8-9: Commented out WebSocket client imports.The imports for
SpeakWebSocketClientandAsyncSpeakWebSocketClienthave been commented out. This aligns with the PR's objective to temporarily remove the TTS WebSocket implementation.
14-14: Commented out WebSocket options import.The import for
SpeakWebSocketOptionshas been commented out, consistent with the removal of the TTS WebSocket implementation.
21-28: Commented out WebSocket response imports.The imports for various WebSocket response types have been commented out. This is consistent with the temporary removal of the TTS WebSocket functionality.
38-38: Commented out WebSocket options declaration.The declaration for
SpeakWebSocketOptionshas been commented out, consistent with the removal of the TTS WebSocket implementation.
45-52: Commented out WebSocket response declarations.The declarations for various WebSocket response types have been commented out. This aligns with the PR's objective to temporarily remove the TTS WebSocket implementation.
62-63: Commented out WebSocket client declarations.The declarations for
SpeakWebSocketClientandAsyncSpeakWebSocketClienthave been commented out. This is consistent with the temporary removal of the TTS WebSocket functionality.deepgram/clients/__init__.py (2)
108-108: Commented out WebSocket options import.The import for
SpeakWebSocketOptionshas been commented out, consistent with the removal of the TTS WebSocket implementation.
128-142: Commented out WebSocket client and response imports.The imports for
SpeakWebSocketClient,AsyncSpeakWebSocketClient, and various WebSocket response types have been commented out. This aligns with the PR's objective to temporarily remove the TTS WebSocket implementation.deepgram/__init__.py (2)
99-99: Verify the temporary removal ofSpeakWebSocketOptions.The
SpeakWebSocketOptionsimport is commented out, which aligns with the PR objectives of temporarily removing the TTS WebSocket implementation.Ensure that this change is temporary and will be reintroduced in a subsequent pull request as mentioned in the PR description.
118-132: Verify the temporary removal of WebSocket-related imports and declarations.The WebSocket-related imports and declarations are commented out, which aligns with the PR objectives of temporarily removing the TTS WebSocket implementation.
Ensure that these changes are temporary and will be reintroduced in a subsequent pull request as mentioned in the PR description.
Proposed changes
Temporarily Remove TTS WS Implementation. Will have a subsequent PR to be held for merge when the feature is ready.
Types of changes
What types of changes does your code introduce to the community Python SDK?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
NA
Summary by CodeRabbit