Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Import of Verboselogs Package Dependency #417

Merged

Conversation

davidvonthenen
Copy link
Contributor

@davidvonthenen davidvonthenen commented Jun 12, 2024

Proposed changes

This fixes the import of the verbose logs package to resolve the missing dependency. Verified broken in test/dev build dev.1.

Types of changes

What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

NA

Summary by CodeRabbit

  • Refactor
    • Updated import paths for the verboselogs module across multiple files to use relative imports. This change improves the maintainability and readability of the codebase.

Copy link
Contributor

coderabbitai bot commented Jun 12, 2024

Warning

Rate limit exceeded

@dvonthenen has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 33 minutes and 11 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between a3b1b56 and a131919.

Walkthrough

The changes primarily involve modifying import statements across various files in the deepgram module to reference the verboselogs module from a different, more appropriate location. This involves switching from absolute imports to relative imports, ensuring consistency and potentially improving maintainability and readability of the codebase.

Changes

Files/Paths Change Summary
deepgram/__init__.py Changed import from from .client import verboselogs to from .utils.verboselogs import *.
deepgram/audio/microphone/constants.py, deepgram/audio/microphone/microphone.py Updated import from deepgram.utils to relative ...utils.
deepgram/client.py Updated import from deepgram.utils to .utils.
deepgram/clients/analyze/v1/async_client.py, deepgram/clients/analyze/v1/client.py, deepgram/clients/analyze/v1/options.py Updated import from deepgram.utils to ....utils.
deepgram/clients/listen.py, deepgram/clients/read.py Updated import from deepgram.utils to ..utils.
deepgram/clients/live/v1/async_client.py, deepgram/clients/live/v1/client.py Updated import from deepgram.utils to ....utils.
deepgram/clients/manage/v1/async_client.py, deepgram/clients/manage/v1/client.py Updated import from deepgram.utils to ....utils.
deepgram/clients/prerecorded/v1/async_client.py, deepgram/clients/prerecorded/v1/client.py Updated import from deepgram.utils to ....utils.
deepgram/clients/selfhosted/v1/async_client.py, deepgram/clients/selfhosted/v1/client.py Updated import from deepgram.utils to ....utils.
deepgram/clients/speak/v1/async_client.py, deepgram/clients/speak/v1/client.py, deepgram/clients/speak/v1/options.py Updated import from deepgram.utils to ....utils.
deepgram/options.py Updated import from deepgram.utils to .utils.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@davidvonthenen davidvonthenen changed the title Fix Import of Verboselogs Package Fix Import of Verboselogs Package Dependency Jun 12, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Outside diff range and nitpick comments (1)
deepgram/client.py (1)

Line range hint 15-15: Remove unused imports or clarify their usage by adding them to __all__ if they are intended for external use.

- from .clients import TextSource, BufferSource, StreamSource, FileSource, UrlSource, Sentiment
- from .clients import LiveClient, AsyncLiveClient
- from .clients import LiveOptions, LiveTranscriptionEvents

Also applies to: 16-16, 17-17, 18-18, 19-19, 20-20, 27-27, 27-27, 29-29, 30-30

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 195ed28 and e0520f3.

Files selected for processing (21)
  • deepgram/init.py (1 hunks)
  • deepgram/audio/microphone/constants.py (1 hunks)
  • deepgram/audio/microphone/microphone.py (1 hunks)
  • deepgram/client.py (1 hunks)
  • deepgram/clients/analyze/v1/async_client.py (1 hunks)
  • deepgram/clients/analyze/v1/client.py (1 hunks)
  • deepgram/clients/analyze/v1/options.py (1 hunks)
  • deepgram/clients/listen.py (1 hunks)
  • deepgram/clients/live/v1/async_client.py (1 hunks)
  • deepgram/clients/live/v1/client.py (1 hunks)
  • deepgram/clients/manage/v1/async_client.py (1 hunks)
  • deepgram/clients/manage/v1/client.py (1 hunks)
  • deepgram/clients/prerecorded/v1/async_client.py (1 hunks)
  • deepgram/clients/prerecorded/v1/client.py (1 hunks)
  • deepgram/clients/read.py (1 hunks)
  • deepgram/clients/selfhosted/v1/async_client.py (1 hunks)
  • deepgram/clients/selfhosted/v1/client.py (1 hunks)
  • deepgram/clients/speak/v1/async_client.py (1 hunks)
  • deepgram/clients/speak/v1/client.py (1 hunks)
  • deepgram/clients/speak/v1/options.py (1 hunks)
  • deepgram/options.py (1 hunks)
Files skipped from review due to trivial changes (17)
  • deepgram/audio/microphone/constants.py
  • deepgram/audio/microphone/microphone.py
  • deepgram/clients/analyze/v1/async_client.py
  • deepgram/clients/analyze/v1/client.py
  • deepgram/clients/listen.py
  • deepgram/clients/live/v1/async_client.py
  • deepgram/clients/manage/v1/async_client.py
  • deepgram/clients/manage/v1/client.py
  • deepgram/clients/prerecorded/v1/async_client.py
  • deepgram/clients/prerecorded/v1/client.py
  • deepgram/clients/read.py
  • deepgram/clients/selfhosted/v1/async_client.py
  • deepgram/clients/selfhosted/v1/client.py
  • deepgram/clients/speak/v1/async_client.py
  • deepgram/clients/speak/v1/client.py
  • deepgram/clients/speak/v1/options.py
  • deepgram/options.py
Additional context used
Ruff
deepgram/__init__.py

9-9: from .utils import * used; unable to detect undefined names (F403)


10-10: .client.Deepgram imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


10-10: .client.DeepgramClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


11-11: .client.DeepgramClientOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


11-11: .client.ClientOptionsFromEnv imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


12-12: .client.DeepgramApiKeyError imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


12-12: .client.DeepgramModuleError imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


15-15: .client.Listen imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


15-15: .client.Read imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


19-19: .client.TextSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


20-20: .client.BufferSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


21-21: .client.StreamSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


22-22: .client.FileSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


23-23: .client.UrlSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


24-24: .client.Sentiment imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


28-28: .client.LiveTranscriptionEvents imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


29-29: .client.LiveClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


29-29: .client.AsyncLiveClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


30-30: .client.LiveOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


32-32: .client.OpenResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


33-33: .client.LiveResultResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


34-34: .client.MetadataResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


35-35: .client.SpeechStartedResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


36-36: .client.UtteranceEndResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


37-37: .client.CloseResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


38-38: .client.UnhandledResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


39-39: .client.ErrorResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


43-43: .client.PreRecordedClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


43-43: .client.AsyncPreRecordedClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


45-45: .client.PrerecordedOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


46-46: .client.PreRecordedStreamSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


47-47: .client.PrerecordedSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


50-50: .client.AsyncPrerecordedResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


51-51: .client.PrerecordedResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


52-52: .client.SyncPrerecordedResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


56-56: .client.ReadClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


56-56: .client.AsyncReadClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


57-57: .client.AnalyzeClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


57-57: .client.AsyncAnalyzeClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


59-59: .client.AnalyzeOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


60-60: .client.AnalyzeStreamSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


61-61: .client.AnalyzeSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


64-64: .client.AsyncAnalyzeResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


65-65: .client.AnalyzeResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


66-66: .client.SyncAnalyzeResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


70-70: .client.SpeakClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


70-70: .client.AsyncSpeakClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


71-71: .client.SpeakOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


71-71: .client.SpeakStreamSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


71-71: .client.SpeakSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


72-72: .client.SpeakResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


75-75: .client.ManageClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


75-75: .client.AsyncManageClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


77-77: .client.ProjectOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


78-78: .client.KeyOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


79-79: .client.ScopeOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


80-80: .client.InviteOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


81-81: .client.UsageRequestOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


82-82: .client.UsageSummaryOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


83-83: .client.UsageFieldsOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


88-88: .client.Message imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


89-89: .client.Project imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


90-90: .client.ProjectsResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


91-91: .client.MembersResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


92-92: .client.Key imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


93-93: .client.KeyResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


94-94: .client.KeysResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


95-95: .client.ScopesResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


96-96: .client.InvitesResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


97-97: .client.UsageRequest imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


98-98: .client.UsageRequestsResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


99-99: .client.UsageSummaryResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


100-100: .client.UsageFieldsResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


101-101: .client.Balance imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


102-102: .client.BalancesResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


107-107: .client.OnPremClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


108-108: .client.AsyncOnPremClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


109-109: .client.SelfHostedClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


110-110: .client.AsyncSelfHostedClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


114-114: .audio.Microphone imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


116-116: .audio.LOGGING imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


117-117: .audio.CHANNELS imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


118-118: .audio.RATE imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


119-119: .audio.CHUNK imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)

deepgram/client.py

15-15: .clients.TextSource imported but unused (F401)

Remove unused import


16-16: .clients.BufferSource imported but unused (F401)

Remove unused import


17-17: .clients.StreamSource imported but unused (F401)

Remove unused import


18-18: .clients.FileSource imported but unused (F401)

Remove unused import


19-19: .clients.UrlSource imported but unused (F401)

Remove unused import


20-20: .clients.Sentiment imported but unused (F401)

Remove unused import


27-27: .clients.LiveClient imported but unused (F401)

Remove unused import


27-27: .clients.AsyncLiveClient imported but unused (F401)

Remove unused import


29-29: .clients.LiveOptions imported but unused (F401)

Remove unused import


30-30: .clients.LiveTranscriptionEvents imported but unused (F401)

Remove unused import


35-35: .clients.OpenResponse imported but unused (F401)

Remove unused import


36-36: .clients.LiveResultResponse imported but unused (F401)

Remove unused import


37-37: .clients.MetadataResponse imported but unused (F401)

Remove unused import


38-38: .clients.SpeechStartedResponse imported but unused (F401)

Remove unused import


39-39: .clients.UtteranceEndResponse imported but unused (F401)

Remove unused import


40-40: .clients.CloseResponse imported but unused (F401)

Remove unused import


41-41: .clients.ErrorResponse imported but unused (F401)

Remove unused import


42-42: .clients.UnhandledResponse imported but unused (F401)

Remove unused import


47-47: .clients.PreRecordedClient imported but unused (F401)

Remove unused import


48-48: .clients.AsyncPreRecordedClient imported but unused (F401)

Remove unused import


51-51: .clients.PrerecordedOptions imported but unused (F401)

Remove unused import


52-52: .clients.PreRecordedStreamSource imported but unused (F401)

Remove unused import


53-53: .clients.PrerecordedSource imported but unused (F401)

Remove unused import


58-58: .clients.AsyncPrerecordedResponse imported but unused (F401)

Remove unused import


59-59: .clients.PrerecordedResponse imported but unused (F401)

Remove unused import


60-60: .clients.SyncPrerecordedResponse imported but unused (F401)

Remove unused import


64-64: .clients.ReadClient imported but unused (F401)

Remove unused import


64-64: .clients.AsyncReadClient imported but unused (F401)

Remove unused import


65-65: .clients.AnalyzeClient imported but unused (F401)

Remove unused import


65-65: .clients.AsyncAnalyzeClient imported but unused (F401)

Remove unused import


67-67: .clients.AnalyzeOptions imported but unused (F401)

Remove unused import


68-68: .clients.AnalyzeStreamSource imported but unused (F401)

Remove unused import


69-69: .clients.AnalyzeSource imported but unused (F401)

Remove unused import


74-74: .clients.AsyncAnalyzeResponse imported but unused (F401)

Remove unused import


75-75: .clients.AnalyzeResponse imported but unused (F401)

Remove unused import


76-76: .clients.SyncAnalyzeResponse imported but unused (F401)

Remove unused import


80-80: .clients.SpeakClient imported but unused (F401)

Remove unused import


80-80: .clients.AsyncSpeakClient imported but unused (F401)

Remove unused import


81-81: .clients.SpeakOptions imported but unused (F401)

Remove unused import: .clients.SpeakOptions


82-82: .clients.SpeakStreamSource imported but unused (F401)

Remove unused import


82-82: .clients.SpeakSource imported but unused (F401)

Remove unused import


85-85: .clients.SpeakResponse imported but unused (F401)

Remove unused import: .clients.SpeakResponse


88-88: .clients.ManageClient imported but unused (F401)

Remove unused import


88-88: .clients.AsyncManageClient imported but unused (F401)

Remove unused import


90-90: .clients.ProjectOptions imported but unused (F401)

Remove unused import


91-91: .clients.KeyOptions imported but unused (F401)

Remove unused import


92-92: .clients.ScopeOptions imported but unused (F401)

Remove unused import


93-93: .clients.InviteOptions imported but unused (F401)

Remove unused import


94-94: .clients.UsageRequestOptions imported but unused (F401)

Remove unused import


95-95: .clients.UsageSummaryOptions imported but unused (F401)

Remove unused import


96-96: .clients.UsageFieldsOptions imported but unused (F401)

Remove unused import


101-101: .clients.Message imported but unused (F401)

Remove unused import


102-102: .clients.Project imported but unused (F401)

Remove unused import


103-103: .clients.ProjectsResponse imported but unused (F401)

Remove unused import


104-104: .clients.MembersResponse imported but unused (F401)

Remove unused import


105-105: .clients.Key imported but unused (F401)

Remove unused import


106-106: .clients.KeyResponse imported but unused (F401)

Remove unused import


107-107: .clients.KeysResponse imported but unused (F401)

Remove unused import


108-108: .clients.ScopesResponse imported but unused (F401)

Remove unused import


109-109: .clients.InvitesResponse imported but unused (F401)

Remove unused import


110-110: .clients.UsageRequest imported but unused (F401)

Remove unused import


111-111: .clients.UsageRequestsResponse imported but unused (F401)

Remove unused import


112-112: .clients.UsageSummaryResponse imported but unused (F401)

Remove unused import


113-113: .clients.UsageFieldsResponse imported but unused (F401)

Remove unused import


114-114: .clients.Balance imported but unused (F401)

Remove unused import


115-115: .clients.BalancesResponse imported but unused (F401)

Remove unused import


120-120: .clients.OnPremClient imported but unused (F401)

Remove unused import


121-121: .clients.AsyncOnPremClient imported but unused (F401)

Remove unused import


122-122: .clients.SelfHostedClient imported but unused (F401)

Remove unused import


123-123: .clients.AsyncSelfHostedClient imported but unused (F401)

Remove unused import


127-127: .options.ClientOptionsFromEnv imported but unused (F401)

Remove unused import: .options.ClientOptionsFromEnv


128-128: .errors.DeepgramApiKeyError imported but unused (F401)

Remove unused import: .errors.DeepgramApiKeyError

Additional comments not posted (2)
deepgram/clients/analyze/v1/options.py (1)

11-11: The change to a relative import path enhances modularity and maintainability. Good job!

deepgram/client.py (1)

10-10: The change to a relative import path enhances modularity and maintainability. Good job!

deepgram/clients/live/v1/client.py Show resolved Hide resolved
deepgram/__init__.py Outdated Show resolved Hide resolved
deepgram/__init__.py Show resolved Hide resolved
deepgram/clients/analyze/v1/options.py Show resolved Hide resolved
@davidvonthenen davidvonthenen force-pushed the fix-imports-verboselogs branch 3 times, most recently from f163f15 to a3b1b56 Compare June 12, 2024 18:23
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Outside diff range and nitpick comments (1)
deepgram/client.py (1)

Line range hint 15-15: Numerous imports in this file are flagged as unused. If these are intended for external use, consider adding them to __all__ to clarify their purpose.

- from .clients import (
-     TextSource, BufferSource, StreamSource, FileSource, UrlSource, Sentiment,
-     Listen, Read, LiveClient, AsyncLiveClient, LiveOptions, LiveTranscriptionEvents,
-     OpenResponse, LiveResultResponse, MetadataResponse, SpeechStartedResponse, UtteranceEndResponse, CloseResponse, ErrorResponse, UnhandledResponse,
-     PreRecordedClient, AsyncPreRecordedClient, PrerecordedOptions, PreRecordedStreamSource, PrerecordedSource,
-     AsyncPrerecordedResponse, PrerecordedResponse, SyncPrerecordedResponse,
-     ReadClient, AsyncReadClient, AnalyzeClient, AsyncAnalyzeClient, AnalyzeOptions, AnalyzeStreamSource, AnalyzeSource,
-     AsyncAnalyzeResponse, AnalyzeResponse, SyncAnalyzeResponse,
-     SpeakClient, AsyncSpeakClient, SpeakOptions, SpeakStreamSource, SpeakSource, SpeakResponse,
-     ManageClient, AsyncManageClient, ProjectOptions, KeyOptions, ScopeOptions, InviteOptions, UsageRequestOptions, UsageSummaryOptions, UsageFieldsOptions,
-     Message, Project, ProjectsResponse, MembersResponse, Key, KeyResponse, KeysResponse, ScopesResponse, InvitesResponse, UsageRequest, UsageRequestsResponse, UsageSummaryResponse, UsageFieldsResponse, Balance, BalancesResponse,
-     OnPremClient, AsyncOnPremClient, SelfHostedClient, AsyncSelfHostedClient,
-     ClientOptionsFromEnv, DeepgramApiKeyError
- )

Also applies to: 16-16, 17-17, 18-18, 19-19, 20-20, 27-27, 27-27, 29-29, 30-30, 35-35, 36-36, 37-37, 38-38, 39-39, 40-40, 41-41, 42-42, 47-47, 48-48, 51-51, 52-52, 53-53, 58-58, 59-59, 60-60, 64-64, 64-64, 65-65, 65-65, 67-67, 68-68, 69-69, 74-74, 75-75, 76-76, 80-80, 80-80, 81-81, 82-82, 82-82, 85-85, 88-88, 88-88, 90-90, 91-91, 92-92, 93-93, 94-94, 95-95, 96-96, 101-101, 102-102, 103-103, 104-104, 105-105, 106-106, 107-107, 108-108, 109-109, 110-110, 111-111, 112-112, 113-113, 114-114, 115-115, 120-120, 121-121, 122-122, 123-123, 127-127, 128-128

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e0520f3 and a3b1b56.

Files selected for processing (21)
  • deepgram/init.py (1 hunks)
  • deepgram/audio/microphone/constants.py (1 hunks)
  • deepgram/audio/microphone/microphone.py (1 hunks)
  • deepgram/client.py (1 hunks)
  • deepgram/clients/analyze/v1/async_client.py (1 hunks)
  • deepgram/clients/analyze/v1/client.py (1 hunks)
  • deepgram/clients/analyze/v1/options.py (1 hunks)
  • deepgram/clients/listen.py (1 hunks)
  • deepgram/clients/live/v1/async_client.py (1 hunks)
  • deepgram/clients/live/v1/client.py (1 hunks)
  • deepgram/clients/manage/v1/async_client.py (1 hunks)
  • deepgram/clients/manage/v1/client.py (1 hunks)
  • deepgram/clients/prerecorded/v1/async_client.py (1 hunks)
  • deepgram/clients/prerecorded/v1/client.py (1 hunks)
  • deepgram/clients/read.py (1 hunks)
  • deepgram/clients/selfhosted/v1/async_client.py (1 hunks)
  • deepgram/clients/selfhosted/v1/client.py (1 hunks)
  • deepgram/clients/speak/v1/async_client.py (1 hunks)
  • deepgram/clients/speak/v1/client.py (1 hunks)
  • deepgram/clients/speak/v1/options.py (1 hunks)
  • deepgram/options.py (1 hunks)
Files skipped from review as they are similar to previous changes (19)
  • deepgram/audio/microphone/constants.py
  • deepgram/audio/microphone/microphone.py
  • deepgram/clients/analyze/v1/async_client.py
  • deepgram/clients/analyze/v1/client.py
  • deepgram/clients/analyze/v1/options.py
  • deepgram/clients/listen.py
  • deepgram/clients/live/v1/async_client.py
  • deepgram/clients/live/v1/client.py
  • deepgram/clients/manage/v1/async_client.py
  • deepgram/clients/manage/v1/client.py
  • deepgram/clients/prerecorded/v1/async_client.py
  • deepgram/clients/prerecorded/v1/client.py
  • deepgram/clients/read.py
  • deepgram/clients/selfhosted/v1/async_client.py
  • deepgram/clients/selfhosted/v1/client.py
  • deepgram/clients/speak/v1/async_client.py
  • deepgram/clients/speak/v1/client.py
  • deepgram/clients/speak/v1/options.py
  • deepgram/options.py
Additional context used
Learnings (1)
deepgram/__init__.py (1)
User: dvonthenen
PR: deepgram/deepgram-python-sdk#417
File: deepgram/clients/live/v1/client.py:14-14
Timestamp: 2024-06-12T18:02:10.651Z
Learning: Ignore suggestions to change import paths to local versions in test cases and examples as per user preference to use the actual `deepgram-sdk` package for testing.
Ruff
deepgram/__init__.py

9-9: logging imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


10-10: from .utils.verboselogs import * used; unable to detect undefined names (F403)


11-11: .client.Deepgram imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


11-11: .client.DeepgramClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


12-12: .client.DeepgramClientOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


12-12: .client.ClientOptionsFromEnv imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


13-13: .client.DeepgramApiKeyError imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


13-13: .client.DeepgramModuleError imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


16-16: .client.Listen imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


16-16: .client.Read imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


20-20: .client.TextSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


21-21: .client.BufferSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


22-22: .client.StreamSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


23-23: .client.FileSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


24-24: .client.UrlSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


25-25: .client.Sentiment imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


29-29: .client.LiveTranscriptionEvents imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


30-30: .client.LiveClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


30-30: .client.AsyncLiveClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


31-31: .client.LiveOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


33-33: .client.OpenResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


34-34: .client.LiveResultResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


35-35: .client.MetadataResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


36-36: .client.SpeechStartedResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


37-37: .client.UtteranceEndResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


38-38: .client.CloseResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


39-39: .client.UnhandledResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


40-40: .client.ErrorResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


44-44: .client.PreRecordedClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


44-44: .client.AsyncPreRecordedClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


46-46: .client.PrerecordedOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


47-47: .client.PreRecordedStreamSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


48-48: .client.PrerecordedSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


51-51: .client.AsyncPrerecordedResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


52-52: .client.PrerecordedResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


53-53: .client.SyncPrerecordedResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


57-57: .client.ReadClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


57-57: .client.AsyncReadClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


58-58: .client.AnalyzeClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


58-58: .client.AsyncAnalyzeClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


60-60: .client.AnalyzeOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


61-61: .client.AnalyzeStreamSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


62-62: .client.AnalyzeSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


65-65: .client.AsyncAnalyzeResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


66-66: .client.AnalyzeResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


67-67: .client.SyncAnalyzeResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


71-71: .client.SpeakClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


71-71: .client.AsyncSpeakClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


72-72: .client.SpeakOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


72-72: .client.SpeakStreamSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


72-72: .client.SpeakSource imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


73-73: .client.SpeakResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


76-76: .client.ManageClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


76-76: .client.AsyncManageClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


78-78: .client.ProjectOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


79-79: .client.KeyOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


80-80: .client.ScopeOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


81-81: .client.InviteOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


82-82: .client.UsageRequestOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


83-83: .client.UsageSummaryOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


84-84: .client.UsageFieldsOptions imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


89-89: .client.Message imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


90-90: .client.Project imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


91-91: .client.ProjectsResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


92-92: .client.MembersResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


93-93: .client.Key imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


94-94: .client.KeyResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


95-95: .client.KeysResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


96-96: .client.ScopesResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


97-97: .client.InvitesResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


98-98: .client.UsageRequest imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


99-99: .client.UsageRequestsResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


100-100: .client.UsageSummaryResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


101-101: .client.UsageFieldsResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


102-102: .client.Balance imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


103-103: .client.BalancesResponse imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


108-108: .client.OnPremClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


109-109: .client.AsyncOnPremClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


110-110: .client.SelfHostedClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


111-111: .client.AsyncSelfHostedClient imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


115-115: .audio.Microphone imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


117-117: .audio.LOGGING imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


118-118: .audio.CHANNELS imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


119-119: .audio.RATE imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)


120-120: .audio.CHUNK imported but unused; consider removing, adding to __all__, or using a redundant alias (F401)

deepgram/client.py

15-15: .clients.TextSource imported but unused (F401)

Remove unused import


16-16: .clients.BufferSource imported but unused (F401)

Remove unused import


17-17: .clients.StreamSource imported but unused (F401)

Remove unused import


18-18: .clients.FileSource imported but unused (F401)

Remove unused import


19-19: .clients.UrlSource imported but unused (F401)

Remove unused import


20-20: .clients.Sentiment imported but unused (F401)

Remove unused import


27-27: .clients.LiveClient imported but unused (F401)

Remove unused import


27-27: .clients.AsyncLiveClient imported but unused (F401)

Remove unused import


29-29: .clients.LiveOptions imported but unused (F401)

Remove unused import


30-30: .clients.LiveTranscriptionEvents imported but unused (F401)

Remove unused import


35-35: .clients.OpenResponse imported but unused (F401)

Remove unused import


36-36: .clients.LiveResultResponse imported but unused (F401)

Remove unused import


37-37: .clients.MetadataResponse imported but unused (F401)

Remove unused import


38-38: .clients.SpeechStartedResponse imported but unused (F401)

Remove unused import


39-39: .clients.UtteranceEndResponse imported but unused (F401)

Remove unused import


40-40: .clients.CloseResponse imported but unused (F401)

Remove unused import


41-41: .clients.ErrorResponse imported but unused (F401)

Remove unused import


42-42: .clients.UnhandledResponse imported but unused (F401)

Remove unused import


47-47: .clients.PreRecordedClient imported but unused (F401)

Remove unused import


48-48: .clients.AsyncPreRecordedClient imported but unused (F401)

Remove unused import


51-51: .clients.PrerecordedOptions imported but unused (F401)

Remove unused import


52-52: .clients.PreRecordedStreamSource imported but unused (F401)

Remove unused import


53-53: .clients.PrerecordedSource imported but unused (F401)

Remove unused import


58-58: .clients.AsyncPrerecordedResponse imported but unused (F401)

Remove unused import


59-59: .clients.PrerecordedResponse imported but unused (F401)

Remove unused import


60-60: .clients.SyncPrerecordedResponse imported but unused (F401)

Remove unused import


64-64: .clients.ReadClient imported but unused (F401)

Remove unused import


64-64: .clients.AsyncReadClient imported but unused (F401)

Remove unused import


65-65: .clients.AnalyzeClient imported but unused (F401)

Remove unused import


65-65: .clients.AsyncAnalyzeClient imported but unused (F401)

Remove unused import


67-67: .clients.AnalyzeOptions imported but unused (F401)

Remove unused import


68-68: .clients.AnalyzeStreamSource imported but unused (F401)

Remove unused import


69-69: .clients.AnalyzeSource imported but unused (F401)

Remove unused import


74-74: .clients.AsyncAnalyzeResponse imported but unused (F401)

Remove unused import


75-75: .clients.AnalyzeResponse imported but unused (F401)

Remove unused import


76-76: .clients.SyncAnalyzeResponse imported but unused (F401)

Remove unused import


80-80: .clients.SpeakClient imported but unused (F401)

Remove unused import


80-80: .clients.AsyncSpeakClient imported but unused (F401)

Remove unused import


81-81: .clients.SpeakOptions imported but unused (F401)

Remove unused import: .clients.SpeakOptions


82-82: .clients.SpeakStreamSource imported but unused (F401)

Remove unused import


82-82: .clients.SpeakSource imported but unused (F401)

Remove unused import


85-85: .clients.SpeakResponse imported but unused (F401)

Remove unused import: .clients.SpeakResponse


88-88: .clients.ManageClient imported but unused (F401)

Remove unused import


88-88: .clients.AsyncManageClient imported but unused (F401)

Remove unused import


90-90: .clients.ProjectOptions imported but unused (F401)

Remove unused import


91-91: .clients.KeyOptions imported but unused (F401)

Remove unused import


92-92: .clients.ScopeOptions imported but unused (F401)

Remove unused import


93-93: .clients.InviteOptions imported but unused (F401)

Remove unused import


94-94: .clients.UsageRequestOptions imported but unused (F401)

Remove unused import


95-95: .clients.UsageSummaryOptions imported but unused (F401)

Remove unused import


96-96: .clients.UsageFieldsOptions imported but unused (F401)

Remove unused import


101-101: .clients.Message imported but unused (F401)

Remove unused import


102-102: .clients.Project imported but unused (F401)

Remove unused import


103-103: .clients.ProjectsResponse imported but unused (F401)

Remove unused import


104-104: .clients.MembersResponse imported but unused (F401)

Remove unused import


105-105: .clients.Key imported but unused (F401)

Remove unused import


106-106: .clients.KeyResponse imported but unused (F401)

Remove unused import


107-107: .clients.KeysResponse imported but unused (F401)

Remove unused import


108-108: .clients.ScopesResponse imported but unused (F401)

Remove unused import


109-109: .clients.InvitesResponse imported but unused (F401)

Remove unused import


110-110: .clients.UsageRequest imported but unused (F401)

Remove unused import


111-111: .clients.UsageRequestsResponse imported but unused (F401)

Remove unused import


112-112: .clients.UsageSummaryResponse imported but unused (F401)

Remove unused import


113-113: .clients.UsageFieldsResponse imported but unused (F401)

Remove unused import


114-114: .clients.Balance imported but unused (F401)

Remove unused import


115-115: .clients.BalancesResponse imported but unused (F401)

Remove unused import


120-120: .clients.OnPremClient imported but unused (F401)

Remove unused import


121-121: .clients.AsyncOnPremClient imported but unused (F401)

Remove unused import


122-122: .clients.SelfHostedClient imported but unused (F401)

Remove unused import


123-123: .clients.AsyncSelfHostedClient imported but unused (F401)

Remove unused import


127-127: .options.ClientOptionsFromEnv imported but unused (F401)

Remove unused import: .options.ClientOptionsFromEnv


128-128: .errors.DeepgramApiKeyError imported but unused (F401)

Remove unused import: .errors.DeepgramApiKeyError

Additional comments not posted (1)
deepgram/client.py (1)

10-10: The import of verboselogs from .utils is correct and aligns with the PR's objective to fix the import paths.

deepgram/__init__.py Outdated Show resolved Hide resolved
deepgram/__init__.py Show resolved Hide resolved
deepgram/__init__.py Show resolved Hide resolved
@davidvonthenen davidvonthenen force-pushed the fix-imports-verboselogs branch 2 times, most recently from 804c68e to 5be3e05 Compare June 12, 2024 18:36
@davidvonthenen davidvonthenen force-pushed the fix-imports-verboselogs branch from 5be3e05 to a131919 Compare June 12, 2024 18:47
@davidvonthenen davidvonthenen merged commit 344cb46 into deepgram:main Jun 12, 2024
4 checks passed
@davidvonthenen davidvonthenen deleted the fix-imports-verboselogs branch June 12, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants