-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add from_finalize property to LiveTranscriptionEvent interface #356
fix: add from_finalize property to LiveTranscriptionEvent interface #356
Conversation
This simply adds the `from_finalize` property to the `LiveTranscriptionEvent` type, described in [Documentation / Finalize](https://developers.deepgram.com/docs/finalize#finalize-confirmation).
WalkthroughThe pull request introduces a new optional property Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/lib/types/LiveTranscriptionEvent.ts
(1 hunks)
🔇 Additional comments (1)
src/lib/types/LiveTranscriptionEvent.ts (1)
33-33
: Verify alignment with Deepgram documentation.Please ensure that the type definition matches the Deepgram documentation regarding the finalize confirmation process. Could you provide a link to the specific documentation section that describes this property?
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@dbburgess thanks for this PR! I'll get this released today. |
This simply adds the
from_finalize
property to theLiveTranscriptionEvent
type, described in Documentation / Finalize.Summary by CodeRabbit
from_finalize
flag to provide additional event metadata.