Allow type change in ArtifactIndex (Closes #1681) #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For clarity, this enables users to modify the type information in an artifact's metadata. It does not change the associated data in any way. |
brollb
requested changes
May 6, 2020
|
For more clarity on the ramifications of changing the |
…change 1. Change meaninfule commit message when changing the attribute of an Artifact Node. 2. Add a ConfirmDialog with warnings for artifact data type Change and change it only if confirmed.
brollb
requested changes
May 8, 2020
| if (newVal && newVal !== oldVal) { | ||
| const confirmed = opts.confirmation ? await opts.confirmation.call(this, | ||
| opts.nodeName, | ||
| {newValue: newVal, oldValue: oldVal} |
There was a problem hiding this comment.
As a minor point, I am not a fan of packing arguments into an options object unless there are a lot of optional arguments. Otherwise, it obscures the method signature without any real benefit.
umesh-timalsina
force-pushed
the
1681-artifacts-type-change
branch
from
7e280a9 to
f425b7d
Compare
brollb
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.