Skip to content

Commit

Permalink
Remove modal and recreate on open/close. Fixes #1834 (#1835)
Browse files Browse the repository at this point in the history
  • Loading branch information
brollb authored Aug 4, 2020
1 parent 7ae0960 commit 2e2eb2f
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions src/visualizers/panels/WorkerHeader/ComputeDialog.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,13 @@ define([
this.dashboards = await Promise.all(fetchDashboards);

this.$el.modal('show');
this.$el.on('hidden.bs.modal', () => this.onHide());
this.$el.on('hidden.bs.modal', () => this.$el.remove());
};

ComputeDialog.prototype.show = async function() {
await this.initialize();
this.dashboards.forEach(dashboard => dashboard.onShow());
};

ComputeDialog.prototype.onHide = function() {
this.dashboards.forEach(dashboard => dashboard.onHide());
};

return ComputeDialog;
});

0 comments on commit 2e2eb2f

Please sign in to comment.