CI updates (tox + Github workflows) #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofri
force-pushed
the
feat/ci_multiple_tf_versions
branch
2 times, most recently
from
d35485d to
b978d9e
Compare
cofri
force-pushed
the
feat/ci_multiple_tf_versions
branch
7 times, most recently
from
1b8255b to
5e470b0
Compare
cofri
changed the title
Because of bugs in TensorFlow 2.0 and 2.1 when saving/loading custom losses or metrics, these versions are not supported anymore. deel-lip now supports TensorFlow 2.2 and higher. Moreover, we tell pip that Python versions 3.9 and 3.10 are supported. Since Python 3.6 is not maintained anymore, we also removed it from the classifiers.
The tox configuration file is updated to add environments with different Python and TensorFlow versions. This allows to run unit tests with these environments and ensure that the library is stable across Python and TF versions. Note that TensorFlow 2.2 version requires an older version for protobuf package.
Since a unit test uses a Keras gelu activation which was introduced in Tensorflow 2.4, a check is added.
Since the tox configuration file now contains a large number of environments for multiple Python and TensorFlow versions, the targets "make test" and "make test-disable-gpu" now runs only a small subset of the tests. But these tests are representative of the different TF versions.
The current versions were deprecated due to an update on Github workflows. The latest versions are now used for actions/checkout and actions/setup-python
The Github workflows for unit testing are extended to test different Python and TensorFlow versions. Three tests are performed on Github CI with the following combinations: - Python 3.7 and TensorFlow 2.3 - Python 3.9 and TensorFlow 2.7 - Python 3.10 and TensorFlow latest (2.10 as of october 2022)
The Github workflows for linting and testing are done when: - a pull request is open (and updated) - pushing on master and develop Moreover, the unit tests are also performed: - every Sunday at 2am on master (i.e. the base branch)
The aim of this commit is to have the package version at a single place, and not across multiple files. The VERSION file contains the version number. It is now the only place where it is set. The setup.py and the Sphinx conf.py read this file. It is now possible to get the version number directly from the package: import deel.lip print(deel.lip.__version__) Note that to add non-Python files to the sdist package, it is required to add `include_package_data=True` in setup.py and a MANIFEST.in file containing the non-Python files to add in package.
cofri
force-pushed
the
feat/ci_multiple_tf_versions
branch
from
5e470b0 to
341bae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements have been made in the continuous integration pipeline:
py3.7 + TF2.3,py3.9 + TF2.7,py3.10 + TF-latestcheckoutandsetup-python) are updatedMoreover, two changes were added:
deel.lip.__version__.