Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing paging for chirps on Scala #1878

Merged
merged 83 commits into from
Jun 25, 2024
Merged

Implementing paging for chirps on Scala #1878

merged 83 commits into from
Jun 25, 2024

Conversation

osm-alt
Copy link
Contributor

@osm-alt osm-alt commented May 18, 2024

Implementing paging for chirps with paged catchup on Scala

osm-alt added 18 commits May 12, 2024 14:57
@osm-alt
Added paged_catchup to HighLevelProtocol.scala
a944f07
@osm-alt
Added PagedCatchup object to method folder in network
a043fd9
@osm-alt
Added paged catchup to PublishSubscribe.scala
2e79e26
@osm-alt
Added catchupHandler function in ParamsHandler.scala
a6e3aae
@osm-alt
Added paged catchup to AnswerGenerator.scala and have work-in-progres…
690172a 
…s code in DbActor.scala
@osm-alt
Added tests for paged catchup in HighLevelProtocolSuite.scala and exa…
d7aadca 
…mples in \util\examples\json folder
@osm-alt
Added tests for paged catchup in AnswerGeneratorSuite.scala and examp…
5640276 
…le for paged catchup request for a non-chirps channel
@osm-alt
Merge branch 'work-fe1-omajzoub-chirps-paging-protocol' of https://gi…
5a5daf0 
…thub.com/dedis/popstellar into work-be2-omajzoub-chirps-paging
@osm-alt
Updated examples in utils for paged catchup to match the examples und…
8ac3abe 
…er the protocol folder
@osm-alt
Updated paged catchup test in HighLevelProtocolSuite.scala to fit the…
7e361d1 
… updated example
@osm-alt
Made beforeMessageID an optional parameter in paged catchup
e41a7fa
@osm-alt
Merge branch 'work-fe1-omajzoub-chirps-paging-protocol' of https://gi…
00276d4 
…thub.com/dedis/popstellar into work-be2-omajzoub-chirps-paging
@osm-alt
DbActor paged catchup work in progress
539f085
@osm-alt
Added regex check for channel in paged catchup and implementation for…
1be88d0 
… getting chirps on the general social media feed. Also updated a test
@osm-alt
Fixed bug in DbActor
8d9628f
@osm-alt
Added implementation for paging chirps of a specific user profile
ac65925
@osm-alt
Fixed some error for paged catchup in HighLevelProtocol.scala
e4f319a
@osm-alt
Updated paged catchup in HighLevelProtocol.scala
8325558
@osm-alt osm-alt requested a review from a team as a code owner May 18, 2024 17:38
@osm-alt osm-alt marked this pull request as draft May 18, 2024 17:38
@K1li4nL K1li4nL marked this pull request as ready for review June 22, 2024 14:07
K1li4nL
K1li4nL previously approved these changes Jun 22, 2024
View reviewed changes
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@K1li4nL K1li4nL dismissed their stale review June 22, 2024 14:08

test done

@K1li4nL K1li4nL marked this pull request as draft June 22, 2024 14:08
@osm-alt osm-alt marked this pull request as ready for review June 24, 2024 13:09
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'PoP - Be2-Scala'

Failed conditions
58.9% Coverage on New Code (required ≥ 65%)
4 New Critical Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

K1li4nL
K1li4nL approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving blindly

@K1li4nL K1li4nL added this pull request to the merge queue Jun 25, 2024
Merged via the queue into master with commit daf1620 Jun 25, 2024
15 of 16 checks passed
@K1li4nL K1li4nL deleted the work-be2-omajzoub-chirps-paging branch June 25, 2024 10:33
@Kaz-ookid Kaz-ookid mentioned this pull request Jun 26, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K1li4nL K1li4nL K1li4nL approved these changes

Assignees
No one assigned
Labels
be2-scala
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osm-alt @K1li4nL