Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove copy button for seed #1112

Merged
merged 4 commits into from
Jun 15, 2022
Merged

Remove copy button for seed #1112

merged 4 commits into from
Jun 15, 2022

Conversation

Tyratox
Copy link
Contributor

@Tyratox Tyratox commented Jun 13, 2022

Screenshot 2022-06-13 at 11 57 04

Remove the ability to trivially copy the wallet initialization seed as per the following discussion:

Louis Bettens
8. Juni um 13:35 Uhr
Oh while I'm at it: copypastability of the 12 words. Generally, especially with big time cryptocurrencies, the interface shouldn't allow you to use the clipboard. Why is there an icon to do it? For debugging convenience? spesmilo/electrum#1492

@Tyratox Tyratox added enhancement New feature or request fe1-web labels Jun 13, 2022
@Tyratox Tyratox requested a review from a team as a code owner June 13, 2022 10:00
@Tyratox Tyratox self-assigned this Jun 13, 2022
@bbjubjub2494
Copy link
Collaborator

Works on my machine 👍

Can you look into locking down the copypasting further? It seems like it's possible on the web according to the docs.

bbjubjub2494
bbjubjub2494 previously approved these changes Jun 13, 2022
View reviewed changes
@Tyratox
Copy link
Contributor Author

Tyratox commented Jun 13, 2022 •
edited
Loading

If you want to make it really difficult, I can do that yes. For react-native this is just a matter of removing the selectable property from the text element.

bbjubjub2494
bbjubjub2494 previously approved these changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@bbjubjub2494 bbjubjub2494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, perfect for me.

@sonarqubecloud
Copy link

[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[PoP - Be2-Scala] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[PoP - Fe1-Web] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

zeros-zorro
zeros-zorro approved these changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@zeros-zorro zeros-zorro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbjubjub2494 bbjubjub2494 mentioned this pull request Jun 14, 2022
Closed
6 tasks
Xelowak
Xelowak approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@Xelowak Xelowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Xelowak Xelowak merged commit 812a91d into master Jun 15, 2022
@Xelowak Xelowak deleted the work-fe1-nico-remove-copy-button branch June 15, 2022 14:02
@Tyratox Tyratox mentioned this pull request Feb 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbjubjub2494 bbjubjub2494 bbjubjub2494 approved these changes

@Xelowak Xelowak Xelowak approved these changes

@zeros-zorro zeros-zorro zeros-zorro approved these changes

Assignees

@Tyratox Tyratox

Labels
enhancement New feature or request fe1-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tyratox @bbjubjub2494 @Xelowak @zeros-zorro