-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[watch only] Watch only transaction #1864
Conversation
89b3544
to
411ebd2
Compare
Only small issue is that in trezor-enabled wallets, you shouldn't show the unsigned transaction, but rather continue with the signing flow (which should send the sign request to trezor). You can manually set a wallet as using trezor (to test out the behavior, even if you can't sign it) by modifying the wallet's |
fixed |
I'm still seeing the raw constructed transaction on the trezor wallet, which is unnecessary. |
8fc9e38
to
2d5bdab
Compare
My bad. Removed it now. One thing I noticed, is that when in trezor mode, the wallet seems to not turn it off, when switching between wallets. |
Yeah, I had noticed that bug earlier in regards to the sidebar. Fixed in #1876. One last nit: transactions can be big and overflow the white area (eg): |
fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This will be nice to have!
closes #1682
I need to rebase, so if can test in trezor mode, that would be great.