introduce stakepoold connection manager #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Validated on testnet, works as expected |
dajohi
approved these changes
May 23, 2019
girino
added a commit
to girino/dcrstakepool
that referenced
this pull request
Sep 7, 2019
* commit '32d75352ba2290c33767151205a2de6e26df7b15': introduce stakepoold connection manager (decred#381)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dcrstakepoolconnects to multiple instances ofstakepooldanddcrwalletover gRPC. The code managing thedcrwalletgRPC connections is significantly more robust than thestakepooldcounterpart.dcrwalletconnections are managed in a single place - namely dcrclient.go. This file is responsible for comms to the multipledcrwalletconnections, error handling, retrying etc. Management ofstakepooldconnections is scattered throughout the code.This PR introduces a connection manager for the stakepoold connections, similar to what exists for dcrwallet. Making stakepoold connection management more robust will become important in the future as we take further steps towards #227 and the
dcrwalletconnections are removed. The PR only refactors existing code and does not add any new functionality.Marking the PR as a draft because I would like to properly validate the work on testnet before it is merged. Not possible right now because testnet blocks are not being mined