Skip to content

Commit

Permalink
allow clicks on any part of row, not just checkbox (#367)
Browse files Browse the repository at this point in the history
  • Loading branch information
jholdstock authored and dajohi committed May 2, 2019
1 parent d1681ea commit 65c3a37
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 8 deletions.
22 changes: 18 additions & 4 deletions views/admin/tickets.html
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,24 @@ <h1 class="d-flex justify-content-between align-items-end">


<script type="text/javascript">
var elements = document.getElementsByClassName("js-only");
for (var i = 0; i < elements.length; i++) {
elements[i].style.display = "block";
}
(function() {
// Display elements with class js-only
var elements = document.getElementsByClassName("js-only");
for (var i = 0; i < elements.length; i++) {
elements[i].style.display = "block";
}

// Change checkbox state if user clicks anywhere on the row.
// Not just the actual checkbox
var rows = document.getElementsByTagName("tr")
for (var i = 0; i < rows.length; i++) {
rows[i].addEventListener("click", function() {
box = this.querySelector("input[type=checkbox]");
box.checked = !box.checked
});
}

})();
</script>

</div>
Expand Down
13 changes: 9 additions & 4 deletions views/stats.html
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,15 @@ <h1>VSP Tickets</h1>
</style>

<script type="text/javascript">
var elements = document.getElementsByClassName("js-only");
for (var i = 0; i < elements.length; i++) {
elements[i].style.display = "flex";
}
(function() {

// Display elements with class js-only
var elements = document.getElementsByClassName("js-only");
for (var i = 0; i < elements.length; i++) {
elements[i].style.display = "flex";
}

})();
</script>

<noscript>
Expand Down

0 comments on commit 65c3a37

Please sign in to comment.