Parse Binance API error response #2912
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
reviewed
Aug 12, 2024
peterzen
force-pushed
the
binance-api-req
branch
from
7082fbf
to
ac3a51c
Compare
JoeGruffins
approved these changes
Aug 28, 2024
peterzen
force-pushed
the
binance-api-req
branch
2 times, most recently
from
4adf0f7
to
ac3a51c
Compare
buck54321
reviewed
Nov 18, 2024
Comment on lines
-1920
to
+1939
| return dexnet.Do(req, thing, dexnet.WithSizeLimit(1<<24)) | ||
| var sizeLimit int64 = 1 << 24 | ||
|
|
||
| resp, err := http.DefaultClient.Do(req) | ||
| if err != nil { | ||
| return fmt.Errorf("error performing request: %w", err) | ||
| } | ||
| defer resp.Body.Close() | ||
| // https://binance-docs.github.io/apidocs/websocket_api/en/#response-format | ||
| if resp.StatusCode != http.StatusOK { | ||
| var apiResp BNApiResponse | ||
| reader := io.LimitReader(resp.Body, sizeLimit) | ||
| if err = json.NewDecoder(reader).Decode(&apiResp); err != nil { | ||
| return fmt.Errorf("error decoding response: %w", err) | ||
| } | ||
| return fmt.Errorf("API error %d: %s (%d)", resp.StatusCode, apiResp.Msg, apiResp.Code) | ||
| } |
There was a problem hiding this comment.
Let's just add this functionality to dexnet. 50005f4...buck54321:dexnet-errparse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change parses API error details from error responses.